Make the mocker typescript tests fail on typescript errors + make tsocnfig slightly stricter #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig slightly stricter
JasoonS
commented
Mar 26, 2025
| "build": "tsc --build", | ||
| "watch": "tsc --watch", | ||
| "mocha": "ts-mocha test/**/*.ts", | ||
| "mocha": "ts-mocha -p tsconfig.json --require ts-node/register --exit test/**/*.ts", |
There was a problem hiding this comment.
Without this you can litraly put code like this in your typescript tests and they just pass 😬
let wrongType: boolean = "true"; // Hint - it is a string
console.log(wrongType, typeof wrongType, "wrongType");
JasoonS
commented
Mar 26, 2025
Comment on lines
+16
to
+20
| "strictNullChecks": true, | ||
| "strictFunctionTypes": true, | ||
| "strictPropertyInitialization": true, | ||
| "noImplicitThis": true, | ||
| "alwaysStrict": true |
There was a problem hiding this comment.
I thought it is good to add these flags too.
There was a problem hiding this comment.
I'd stick to the guideline https://www.totaltypescript.com/tsconfig-cheat-sheet
There was a problem hiding this comment.
🙏 - awesome. Thanks, will give that a read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.