Skip to content

Make the mocker typescript tests fail on typescript errors + make tsocnfig slightly stricter #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the mocker typescript tests fail on typescript errors + make tsocnfig slightly stricter #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codegenerator/cli/templates/dynamic/init_templates/shared/package.json.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"clean": "tsc --clean",
"build": "tsc --build",
"watch": "tsc --watch",
"mocha": "ts-mocha test/**/*.ts",
"mocha": "ts-mocha -p tsconfig.json --require ts-node/register --exit test/**/*.ts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this you can litraly put code like this in your typescript tests and they just pass 😬

    let wrongType: boolean = "true"; // Hint - it is a string
    console.log(wrongType, typeof wrongType, "wrongType");

{{/if}}
{{#if is_rescript}}
"clean": "rescript clean",
Expand Down
7 changes: 6 additions & 1 deletion codegenerator/cli/templates/static/blank_template/typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@
"esModuleInterop": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"module": "CommonJS"
"module": "CommonJS",
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true
Comment on lines +16 to +20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it is good to add these flags too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd stick to the guideline https://www.totaltypescript.com/tsconfig-cheat-sheet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 - awesome. Thanks, will give that a read

},
"include": [
"src",
Expand Down