-
Notifications
You must be signed in to change notification settings - Fork 7
use uncached ranges for esp32p4 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
297f7c1 to
db8603f
Compare
ld/esp32p4.x
Outdated
| /* Start 64k into the uncached RAM region */ | ||
| IRAM : ORIGIN = 0x8FF30000, LENGTH = 0x10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you push this over to 0x8FF50000 instead? ROM code in older devices use RAM up until 0x4ff40000, and probe-rs places breakpoints before the algo. Besides, the 64k in the comment is wrong, although that's not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved it to 0x8ff40020, which works.
src/main.rs
Outdated
| // ESP32-C61 | 0x4081_0000 | 0x4081_0000 | 0x4082_0000 | 0x4083_0000 | 0x4083_8000 !! ROM data use starts at 0x4083EA70, so let's use H2's memory layout | ||
| // ESP32-H2 | 0x4081_0000 | 0x4081_0000 | 0x4082_0000 | 0x4083_0000 | 0x4083_8000 !! has smaller RAM, only reserve 32K for data | ||
| // ESP32-P4 | 0x4FF1_0000 | 0x4FF1_0000 | 0x4FF6_0000 | 0x4FF7_0000 | 0x4FFC_0000 | ||
| // ESP32-P4 | 0x8FF3_0000 | 0x8FF3_0000 | 0x8FF6_0000 | 0x8FF7_0000 | 0x8FFC_0000 !! Uncached region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // ESP32-P4 | 0x8FF3_0000 | 0x8FF3_0000 | 0x8FF6_0000 | 0x8FF7_0000 | 0x8FFC_0000 !! Uncached region | |
| // ESP32-P4 | 0x8FF3_0000 | 0x8FF3_0000 | 0x8FF6_0000 | 0x8FF7_0000 | 0x8FF8_0000 !! Uncached region |
This doesn't really change anything, but because ROM functions in newer chips use the end of RAM, let's shrink our documented range a bit :)
db8603f to
25c938a
Compare
This moves the flash algorithm into uncached ranges as required for version 3.0 of the chip.
25c938a to
42a8733
Compare
This moves the flash algorithm into uncached ranges as required for version 3.0 of the chip.