-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstabilize CPU-related functionality, merge modules #3099
Conversation
fb66996
to
aa24ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to bikeshed, I feel like this would be better placed in a system
or soc
module.
Which also brought my attention to https://docs.esp-rs.org/esp-hal/esp-hal/0.23.1/esp32s3/esp_hal/system/index.html which probably should be hidden completely I think?
Good shout, although that system module is equally pointless IMHO Radio clocks belong to maybe |
Yep, I agree with all those points! |
6ca612a
to
1813d51
Compare
a4954df
to
d798995
Compare
I moved everything into The Peripheral enum can and should probably be generated based on data in the soc::peripherals module, but for now it should be fine as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question that I either can't tell from the diff or has some other effect I'm not considering
Multi-core operations, as well as CPU reset are no longer stable. CPU-related operations are now contained in the
cpu
module (as well as system reset, which may be slightly awkward but keeping that alone in a separate reset module seemed equally weird).This PR also fixed CPU reset. In esp-idf, the rom function is defined as
void esp_rom_software_reset_cpu(int cpu_no);
and we were missing thecpu_no
parameter. Because of this change, the function is no longer marked as stable.I think these were the last bits in esp-hal that weren't supposed to be stable.