Skip to content

fix: backward-compat for ESM etherpad#157

Merged
SamTV12345 merged 1 commit into
mainfrom
fix/esm-compat
May 25, 2026
Merged

fix: backward-compat for ESM etherpad#157
SamTV12345 merged 1 commit into
mainfrom
fix/esm-compat

Conversation

@SamTV12345

Copy link
Copy Markdown
Member

This PR makes the plugin backward-compatible with the upcoming ESM etherpad branch (ether/etherpad#7605).

Change: Remove trailing slash from require("ep_etherpad-lite/node/eejs/")require("ep_etherpad-lite/node/eejs")

The trailing-slash form breaks under Node's strict ESM exports map resolution. This change is backward-compatible with the current CJS etherpad release.

- Drop trailing slash on ep_etherpad-lite/node/eejs/ require

Backward-compatible with current CJS etherpad release; also
compatible with the upcoming ESM etherpad branch which has stricter
exports map resolution.
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Review Summary by Qodo

Remove trailing slash for ESM etherpad compatibility

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Remove trailing slash from eejs require path
• Ensures ESM etherpad compatibility with strict exports
• Maintains backward compatibility with current CJS release
• Bump version to 0.7.8
Diagram
flowchart LR
  A["require with trailing slash"] -- "remove trailing slash" --> B["require without trailing slash"]
  B -- "compatible with" --> C["ESM etherpad"]
  B -- "compatible with" --> D["CJS etherpad"]

Loading

File Changes

1. eejs.js 🐞 Bug fix +1/-1

Remove trailing slash from eejs require

• Remove trailing slash from require('ep_etherpad-lite/node/eejs/') to
 require('ep_etherpad-lite/node/eejs')
• Fixes strict ESM exports map resolution in upcoming etherpad branch
• Maintains backward compatibility with current CJS etherpad release

eejs.js


2. package.json ⚙️ Configuration changes +1/-1

Update version to 0.7.8

• Bump version from 0.7.7 to 0.7.8

package.json


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented May 25, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1)

Grey Divider


Action required

1. eejs require change untested 📘 Rule violation ☼ Reliability
Description
This PR fixes an ESM compatibility bug by changing the require() path, but it does not add or
update any automated regression test. Without a test, the ESM/CJS resolution issue can silently
regress in future changes.
Code

eejs.js[3]

Evidence
Compliance ID 1 requires a regression test for each bug fix. The PR changes runtime behavior in
eejs.js (the ESM compatibility fix), and the project has no test script configured in
package.json, indicating no regression test was added alongside the fix.

AGENTS.md: Every Bug Fix Must Include a Regression Test
eejs.js[1-9]
package.json[35-38]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A bug fix was made (changing the `require('ep_etherpad-lite/node/eejs/')` import to remove the trailing slash), but no regression test was added/updated to ensure this compatibility behavior does not regress.

## Issue Context
Compliance requires that every bug fix includes an automated test that would fail before the fix and pass after it. The repository also lacks any test runner configuration in `package.json`.

## Fix Focus Areas
- eejs.js[1-9]
- package.json[35-38]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Comment thread eejs.js
'use strict';

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. eejs require change untested 📘 Rule violation ☼ Reliability

This PR fixes an ESM compatibility bug by changing the require() path, but it does not add or
update any automated regression test. Without a test, the ESM/CJS resolution issue can silently
regress in future changes.
Agent Prompt
## Issue description
A bug fix was made (changing the `require('ep_etherpad-lite/node/eejs/')` import to remove the trailing slash), but no regression test was added/updated to ensure this compatibility behavior does not regress.

## Issue Context
Compliance requires that every bug fix includes an automated test that would fail before the fix and pass after it. The repository also lacks any test runner configuration in `package.json`.

## Fix Focus Areas
- eejs.js[1-9]
- package.json[35-38]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@SamTV12345 SamTV12345 merged commit d6aa385 into main May 25, 2026
5 checks passed
@SamTV12345 SamTV12345 deleted the fix/esm-compat branch May 25, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant