Skip to content

fix: backward-compat for ESM etherpad #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. eejs require change untested 📘 Rule violation ☼ Reliability

This PR fixes an ESM compatibility bug by changing the require() path, but it does not add or
update any automated regression test. Without a test, the ESM/CJS resolution issue can silently
regress in future changes.
Agent Prompt 
## Issue description
A bug fix was made (changing the `require('ep_etherpad-lite/node/eejs/')` import to remove the trailing slash), but no regression test was added/updated to ensure this compatibility behavior does not regress.

## Issue Context
Compliance requires that every bug fix includes an automated test that would fail before the fix and pass after it. The repository also lacks any test runner configuration in `package.json`.

## Fix Focus Areas
- eejs.js[1-9]
- package.json[35-38]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


exports.eejsBlock_body = (hookName, args, cb) => {
const templateFile = 'ep_set_title_on_pad/templates/title.ejs';
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ep_set_title_on_pad",
"description": "Set the title on a pad in Etherpad, also includes real time updates to the UI",
"version": "0.7.7",
"version": "0.7.8",
"license": "Apache-2.0",
"author": "johnyma22 (John McLear) <john@mclear.co.uk>",
"keywords": [
Expand Down
Loading