Fix backend-tests find path for plugin test discovery#7397
Merged
Conversation
plugins i --path installs to src/plugin_packages/, not node_modules/. Update the find command to look in the correct location so backend tests are actually discovered and run. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Review Summary by QodoFix backend test discovery path for plugins
WalkthroughsDescription• Fix backend test discovery path in CI workflow • Update find command to search in src/plugin_packages/ • Correct plugin installation location reference Diagramflowchart LR
A["Plugin Installation<br/>src/plugin_packages/"] -- "find command" --> B["Backend Test Discovery<br/>Updated Path"]
C["Old Path<br/>node_modules/"] -.->|incorrect| B
File Changes1. bin/plugins/lib/backend-tests.yml
|
Code Review by Qodo
1. find path fix untested
|
| working-directory: ./etherpad-lite | ||
| run: | | ||
| res=$(find .. -path "./node_modules/ep_*/static/tests/backend/specs/**" | wc -l) | ||
| res=$(find . -path "./src/plugin_packages/ep_*/static/tests/backend/specs/**" | wc -l) |
There was a problem hiding this comment.
1. find path fix untested 📘 Rule violation ⛯ Reliability
This PR fixes backend test discovery by changing the plugin search path, but it does not add any regression test that would fail if the change were reverted. Without a regression test, the same CI discovery bug could be reintroduced without detection.
Agent Prompt
## Issue description
The PR fixes backend test discovery in CI, but does not add a regression test that would fail if the fix were reverted.
## Issue Context
This change adjusts where plugins are searched for backend tests (`src/plugin_packages` instead of `node_modules`). A regression test should validate that backend tests are discovered from the intended install location so the bug cannot silently return.
## Fix Focus Areas
- bin/plugins/lib/backend-tests.yml[65-65]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugins i --path installs to src/plugin_packages/, not node_modules/. Update the find command to look in the correct location so backend tests are actually discovered and run.