Skip to content

Fix backend-tests find path for plugin test discovery#7397

Merged
JohnMcLear merged 1 commit into
ether:developfrom
JohnMcLear:fix/backend-tests-find-path
Mar 30, 2026
Merged

Fix backend-tests find path for plugin test discovery#7397
JohnMcLear merged 1 commit into
ether:developfrom
JohnMcLear:fix/backend-tests-find-path

Conversation

@JohnMcLear

Copy link
Copy Markdown
Member

plugins i --path installs to src/plugin_packages/, not node_modules/. Update the find command to look in the correct location so backend tests are actually discovered and run.

plugins i --path installs to src/plugin_packages/, not node_modules/.
Update the find command to look in the correct location so backend
tests are actually discovered and run.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Review Summary by Qodo

Fix backend test discovery path for plugins

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Fix backend test discovery path in CI workflow
• Update find command to search in src/plugin_packages/
• Correct plugin installation location reference
Diagram
flowchart LR
  A["Plugin Installation<br/>src/plugin_packages/"] -- "find command" --> B["Backend Test Discovery<br/>Updated Path"]
  C["Old Path<br/>node_modules/"] -.->|incorrect| B
Loading

Grey Divider

File Changes

1. bin/plugins/lib/backend-tests.yml 🐞 Bug fix +1/-1

Update find path for plugin test discovery

• Updated find command search path from ../node_modules/ to ./src/plugin_packages/
• Corrects plugin test discovery to match actual installation location
• Ensures backend tests are properly discovered and executed in CI

bin/plugins/lib/backend-tests.yml


Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Mar 30, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0)

Grey Divider


Action required

1. find path fix untested 📘 Rule violation ⛯ Reliability
Description
This PR fixes backend test discovery by changing the plugin search path, but it does not add any
regression test that would fail if the change were reverted. Without a regression test, the same CI
discovery bug could be reintroduced without detection.
Code

bin/plugins/lib/backend-tests.yml[65]

+          res=$(find . -path "./src/plugin_packages/ep_*/static/tests/backend/specs/**" | wc -l)
Evidence
The checklist requires a regression test for bug fixes (PR Compliance ID 1). The only change in this
PR is the workflow find path update in backend-tests.yml, and no test additions/changes are
present in the provided diff.

bin/plugins/lib/backend-tests.yml[65-65]
Best Practice: Repository guidelines

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The PR fixes backend test discovery in CI, but does not add a regression test that would fail if the fix were reverted.

## Issue Context
This change adjusts where plugins are searched for backend tests (`src/plugin_packages` instead of `node_modules`). A regression test should validate that backend tests are discovered from the intended install location so the bug cannot silently return.

## Fix Focus Areas
- bin/plugins/lib/backend-tests.yml[65-65]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@JohnMcLear JohnMcLear merged commit 45fe8a3 into ether:develop Mar 30, 2026
23 checks passed
working-directory: ./etherpad-lite
run: |
res=$(find .. -path "./node_modules/ep_*/static/tests/backend/specs/**" | wc -l)
res=$(find . -path "./src/plugin_packages/ep_*/static/tests/backend/specs/**" | wc -l)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. find path fix untested 📘 Rule violation ⛯ Reliability

This PR fixes backend test discovery by changing the plugin search path, but it does not add any
regression test that would fail if the change were reverted. Without a regression test, the same CI
discovery bug could be reintroduced without detection.
Agent Prompt
## Issue description
The PR fixes backend test discovery in CI, but does not add a regression test that would fail if the fix were reverted.

## Issue Context
This change adjusts where plugins are searched for backend tests (`src/plugin_packages` instead of `node_modules`). A regression test should validate that backend tests are discovered from the intended install location so the bug cannot silently return.

## Fix Focus Areas
- bin/plugins/lib/backend-tests.yml[65-65]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant