Skip to content

Fix backend-tests find path for plugin test discovery #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
Mar 30, 2026
Merged

Fix backend-tests find path for plugin test discovery #7397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/plugins/lib/backend-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
name: Run the backend tests
working-directory: ./etherpad-lite
run: |
res=$(find .. -path "./node_modules/ep_*/static/tests/backend/specs/**" | wc -l)
res=$(find . -path "./src/plugin_packages/ep_*/static/tests/backend/specs/**" | wc -l)

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Mar 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. find path fix untested 📘 Rule violation ⛯ Reliability

This PR fixes backend test discovery by changing the plugin search path, but it does not add any
regression test that would fail if the change were reverted. Without a regression test, the same CI
discovery bug could be reintroduced without detection.
Agent Prompt 
## Issue description
The PR fixes backend test discovery in CI, but does not add a regression test that would fail if the fix were reverted.

## Issue Context
This change adjusts where plugins are searched for backend tests (`src/plugin_packages` instead of `node_modules`). A regression test should validate that backend tests are discovered from the intended install location so the bug cannot silently return.

## Fix Focus Areas
- bin/plugins/lib/backend-tests.yml[65-65]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

if [ $res -eq 0 ]; then
echo "No backend tests found"
else
Expand Down
Loading