chore(op-e2e): replace op-supervisor with op-supernode in super_test path#20825
Merged
ajsutton merged 6 commits intoMay 18, 2026
Merged
Conversation
…path SuperSystem now boots a single op-supernode that owns one virtual op-node per L2 chain, instead of running a standalone op-supervisor alongside separate op-nodes. Per-chain CL RPC is reached at <supernode>/<chainID>; batcher RollupRpc and dispute helpers use that routed URL. Migrated dispute game helpers to SuperNodeRootProvider / SuperNodePrestate and Trace providers, set cfg.UseSuperNode in the challenger helper, and swapped supervisor SyncStatus accessors for their supernode equivalents (SafeTimestamp/CurrentL1.Number; chain.UnsafeL2.Time). op-e2e/interop/interop_test.go deleted: only exercised op-supervisor RPCs (FinalizedL1, CheckAccessList, AddL2RPC) that have no supernode counterpart and are owned by op-supernode and op-acceptance-tests now. Action tests under op-e2e/actions/interop/ are intentionally untouched and continue to use op-supervisor. TestCreateSuperCannonGame passes locally end-to-end against the new SuperSystem. Towards #20814.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #20825 +/- ##
===========================================
- Coverage 76.2% 66.3% -10.0%
===========================================
Files 185 55 -130
Lines 10671 4035 -6636
===========================================
- Hits 8141 2677 -5464
+ Misses 2386 1214 -1172
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…tDial The super-cannon trace provider returns ErrNotInSync until the supernode's CurrentL1 has advanced past the game's l1Head. Right after game creation the supernode can still be a block or two behind, so the very first correctClaimValue lookup races the sync and the test fatals with "local node too far behind". Centralise the wait in FactoryHelper.GetL1Head (super-system only) so every super-game path picks it up without scattering retries through individual call sites. Also drop the now-unused mustDial helper (lint failure).
…fType The wait belongs next to the trace-provider construction it gates, not inside GetL1Head which is a generic accessor. Also shrink the helper's doc comment.
karlfloersch
approved these changes
May 18, 2026
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
LGTM. Shared a 'finding' that my codex had
wwared
approved these changes
May 18, 2026
Contributor
wwared
left a comment
wwared
left a comment
There was a problem hiding this comment.
LGTM, non-blocking notes below
…al ctx for waitForSupernodePastL1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuperSystem now boots a single op-supernode that owns one virtual op-node per L2 chain, instead of running a standalone op-supervisor alongside separate op-nodes. Per-chain CL RPC is reached at `/`; the batcher's `RollupRpc` and the dispute helpers use that routed URL.
`op-e2e/interop/interop_test.go` is deleted — it only exercised op-supervisor RPCs (`FinalizedL1`, `CheckAccessList`, `AddL2RPC`) that have no supernode counterpart and are now covered by op-supernode and op-acceptance-tests.
Action tests under `op-e2e/actions/interop/` are intentionally untouched and continue to use op-supervisor.
Towards #20814.
Test plan