feat(cli): resolve updated execution_spec exceptions #1784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
type:feat
spencer-tb
changed the title
4 tasks
| TransactionException.INSUFFICIENT_ACCOUNT_FUNDS: "Failed transaction: InsufficientBalanceError('insufficient sender balance')", | ||
| TransactionException.TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED: "Failed transaction: BlobGasLimitExceededError('blob gas limit exceeded')", | ||
| TransactionException.INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: "Failed transaction: InsufficientMaxFeePerBlobGasError('insufficient max fee per blob gas')", | ||
| TransactionException.INSUFFICIENT_MAX_FEE_PER_GAS: "Failed transaction: InsufficientMaxFeePerGasError('Insufficient max fee per gas", |
There was a problem hiding this comment.
We should probably stay consistent with capitalization in the messages. Other than that, looks good 😄
There was a problem hiding this comment.
makes sense! since this requires changes on the execution-spec side as well - should we tackle it now or track with an issue for now?
souradeep-das
commented
Jul 17, 2025
Comment on lines
+4
to
+5
| "branch": "forks/osaka", | ||
| "commit": "7b1694e9a0b7647c6d53d1bddbf96454a875e7fa" |
There was a problem hiding this comment.
ethereum/execution-specs#1286 was merged in forks/osaka so this is a commit from that branch. Not sure if we should wait for forks/osaka to be merged before merging this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Specific exceptions were added to execution_spec
InvalidTransactiontypes. This is a complementary update to accommodate for these specific exceptions.Exception types and details are outlined here:
🔗 Related Issues
ethereum/execution-specs#1021
✅ Checklist