feat: always vector for ExecutionBlockProof types #1779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
reviewed
Apr 24, 2025
Comment on lines
+21
to
+37
| /// The timestamp of the first Merge block (block number: 15537394) | ||
| pub const MERGE_TIMESTAMP: u64 = 1663224179; | ||
|
|
||
| /// The timestamp of the first Shapella (Shanghai-Capella) slot. | ||
| /// | ||
| /// - Slot: 6209536 | ||
| /// - Epoch: 194048 | ||
| /// - Block number: 17034870 | ||
| /// - Note that frst Shapella block is created at slot 6209538 (timestamp: 1681338479) | ||
| pub const SHAPELLA_TIMESTAMP: u64 = 1681338455; | ||
|
|
||
| /// The timestamp of the first Dencun (Cancun-Deneb) slot. | ||
| /// | ||
| /// - Slot: 8626176 | ||
| /// - Epoch: 269568 | ||
| /// - Block number: 19426587 | ||
| pub const DENCUN_TIMESTAMP: u64 = 1710338135; |
There was a problem hiding this comment.
One thing to note is long term instead of using these constants we would be required to pass NetworkSpec which would hold the fork timestamps per network mainnet,sepolia etc
There was a problem hiding this comment.
So in short going forward if we want to support testnets we won't be able to use any global consts for forks
There was a problem hiding this comment.
I will make a followup PR for using NetworkSpec instead of const's. I don't think I have concerns with this PR anymore
|
No need to review this PR. I will split it into smaller PRs and merge separately (I made some changes that are no longer needed, and I want to organize code a bit better) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DEPRECATED] I will split this into multiple PRs. No need for review!
What was wrong?
The spec is changing the type of ExecutionBlockProof to always be Vector. See ethereum/portal-network-specs#396
How was it fixed?
Switch to using Vector for ExecutionBlockProof types.
Add proof generation for Deneb.
Note that tests are passing with combination of following PRs:
To-Do