feature: default orbit in given time #2016
Open
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are modifying libf3d public API! |
mwestphal
reviewed
Feb 24, 2025
library/src/animationManager.cxx
Outdated
| @@ -237,6 +237,24 @@ void animationManager::Tick() | |||
| { | |||
| this->Window.render(); | |||
| } | |||
|
|
|||
| // Check if camera orbit option is enabled | |||
| if (this->Options.scene.camera.orbitTime > 0) | |||
There was a problem hiding this comment.
I dont think camera orbit should be handled in animation, but it should be handled in the eventLoop directly.
There was a problem hiding this comment.
I even think the camera orbit should be handled in the application event loop, not in the lib
mwestphal
reviewed
Feb 24, 2025
| namespace options { | ||
| namespace scene { | ||
| struct camera { | ||
| double orbit_time = 0.0; |
There was a problem hiding this comment.
that not how you add an option, look at options.json :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
--camera-orbitoption and test the option