feature: default orbit in given time #2016
Conversation
|
You are modifying libf3d public API! |
library/src/animationManager.cxx
Outdated
| @@ -237,6 +237,24 @@ void animationManager::Tick() | |||
| { | |||
| this->Window.render(); | |||
| } | |||
|
|
|||
| // Check if camera orbit option is enabled | |||
| if (this->Options.scene.camera.orbitTime > 0) | |||
There was a problem hiding this comment.
I dont think camera orbit should be handled in animation, but it should be handled in the eventLoop directly.
There was a problem hiding this comment.
I even think the camera orbit should be handled in the application event loop, not in the lib
| namespace options { | ||
| namespace scene { | ||
| struct camera { | ||
| double orbit_time = 0.0; |
There was a problem hiding this comment.
that not how you add an option, look at options.json :)
|
my bad : ) |
|
So we discussed it in discord, lets implement that in the application event loop :) |
|
On it 🫡 |
|
Hi @v0id-strike ! Do you need help moving forward ? |
|
Sorry, i was busy with semesters. |
|
No problem, thanks for the feedback. |
added
--camera-orbitoption and test the optionFix: #1743