-
-
Notifications
You must be signed in to change notification settings - Fork 270
feature: default orbit in given time #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
v0id-strike
wants to merge
8
commits into
f3d-app:master
Choose a base branch
from
v0id-strike:CamOrbit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7891186
feature: default orbit in given time
v0id-strike eef32a5
few fixes for `--camera-orbit`
v0id-strike bd3fb9d
refactor
v0id-strike 30594c2
some more fixes
v0id-strike 9da73a1
Fix camera orbit time access
v0id-strike 97d4852
structure
v0id-strike 4c23cdf
refactor: options and orbit handling
v0id-strike 147d1bf
Revert "refactor: options and orbit handling"
v0id-strike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
#include "PseudoUnitTest.h" | ||
|
||
#include <engine.h> | ||
#include <interactor.h> | ||
#include <scene.h> | ||
|
||
int TestCameraOrbit(int argc, char* argv[]) | ||
{ | ||
PseudoUnitTest test; | ||
f3d::engine eng = f3d::engine::create(true); | ||
f3d::scene& sce = eng.getScene(); | ||
f3d::interactor& inter = eng.getInteractor(); | ||
sce.add(std::string(argv[1]) + "/data/f3d.glb"); | ||
|
||
// Set camera orbit time | ||
eng.getOptions().scene.camera.orbit_time = 5.0; // 5 seconds for a full orbit | ||
|
||
inter.startAnimation(); | ||
test("isPlaying after start", inter.isPlayingAnimation()); | ||
|
||
// Simulate some time passing | ||
sce.loadAnimationTime(2.5); // Halfway through the orbit | ||
|
||
// Check camera position | ||
vtkCamera* camera = | ||
sce.getWindow().getRenderWindow()->GetRenderers()->GetFirstRenderer()->GetActiveCamera(); | ||
double* position = camera->GetPosition(); | ||
test("camera x position", std::abs(position[0] - 0.0) < 0.1); // Expect near zero x position | ||
test("camera y position", std::abs(position[1] - 10.0) < 0.1); // Expect near radius y position | ||
|
||
inter.stopAnimation(); | ||
test("isPlaying after stop", !inter.isPlayingAnimation()); | ||
|
||
return test.result(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that not how you add an option, look at
options.json
:)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks