-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options: Add support for path using std::filesystem::path #2046
Conversation
You are modifying libf3d public API! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
==========================================
+ Coverage 95.79% 95.80% +0.01%
==========================================
Files 128 128
Lines 10485 10499 +14
==========================================
+ Hits 10044 10059 +15
+ Misses 441 440 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo, but otherwise it looks good.
I still would like to clarify if we still need the variant, or if we can get rid of variant and actual types, but it's out of scope of this PR
We still need it, but we could deprecate it and remove the API on the next release. Ill open an issue. |
Co-authored-by: Michael MIGLIORE <[email protected]>
_option_variant_convert
logic in f3dOptions.cmake for conversion from an option type to a variant typepath
akastd::filesystem::path
has a valid option typerelated to #1570