Fix RCTTextLayoutManager nullable conversion (#56547)#56547
Closed
fkgozali wants to merge 1 commit into
Closed
Conversation
|
@fkgozali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101920741. |
meta-cla
Bot
added
the
CLA Signed
fkgozali
force-pushed
the
export-D101920741
branch
from
7294583 to
4c7b8bb
Compare
meta-codesync
Bot
changed the title
fkgozali
force-pushed
the
export-D101920741
branch
from
4c7b8bb to
926050a
Compare
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 22, 2026
Summary: The original fix in `RCTTextLayoutManager.mm` used the pattern `[obj UTF8String] != nullptr ? [obj UTF8String] : ""`, but Clang's null analysis still types the first operand as `_Nullable`, so `-Wnullable-to-nonnull-conversion` is still triggered as a hard error under Xcode 26.4. Switch to the local-variable pattern that was already used correctly for `RNTMyNativeViewCommon.mm`: ``` const char *renderedUTF8 = [renderedString UTF8String]; ... std::string(renderedUTF8 != nullptr ? renderedUTF8 : "") ... ``` Changelog: [Internal] Reviewed By: javache Differential Revision: D101920741
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 22, 2026
Summary: Pull Request resolved: facebook#56547 The original fix in `RCTTextLayoutManager.mm` used the pattern `[obj UTF8String] != nullptr ? [obj UTF8String] : ""`, but Clang's null analysis still types the first operand as `_Nullable`, so `-Wnullable-to-nonnull-conversion` is still triggered as a hard error under Xcode 26.4. Switch to the local-variable pattern that was already used correctly for `RNTMyNativeViewCommon.mm`: ``` const char *renderedUTF8 = [renderedString UTF8String]; ... std::string(renderedUTF8 != nullptr ? renderedUTF8 : "") ... ``` Changelog: [Internal] Reviewed By: javache Differential Revision: D101920741
fkgozali
force-pushed
the
export-D101920741
branch
from
926050a to
236e7d1
Compare
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 22, 2026
Summary: The original fix in `RCTTextLayoutManager.mm` used the pattern `[obj UTF8String] != nullptr ? [obj UTF8String] : ""`, but Clang's null analysis still types the first operand as `_Nullable`, so `-Wnullable-to-nonnull-conversion` is still triggered as a hard error under Xcode 26.4. Switch to the local-variable pattern that was already used correctly for `RNTMyNativeViewCommon.mm`: ``` const char *renderedUTF8 = [renderedString UTF8String]; ... std::string(renderedUTF8 != nullptr ? renderedUTF8 : "") ... ``` Changelog: [Internal] Reviewed By: javache Differential Revision: D101920741
fkgozali
force-pushed
the
export-D101920741
branch
from
236e7d1 to
fddf703
Compare
Summary: Pull Request resolved: facebook#56547 The original fix in `RCTTextLayoutManager.mm` used the pattern `[obj UTF8String] != nullptr ? [obj UTF8String] : ""`, but Clang's null analysis still types the first operand as `_Nullable`, so `-Wnullable-to-nonnull-conversion` is still triggered as a hard error under Xcode 26.4. Switch to the local-variable pattern that was already used correctly for `RNTMyNativeViewCommon.mm`: ``` const char *renderedUTF8 = [renderedString UTF8String]; ... std::string(renderedUTF8 != nullptr ? renderedUTF8 : "") ... ``` Changelog: [Internal] Reviewed By: javache Differential Revision: D101920741
fkgozali
force-pushed
the
export-D101920741
branch
from
fddf703 to
f8beb94
Compare
|
This pull request has been merged in 98df9b1. |
Collaborator
|
This pull request was successfully merged by @fkgozali in 98df9b1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The original fix in
RCTTextLayoutManager.mmused the pattern[obj UTF8String] != nullptr ? [obj UTF8String] : "", but Clang's null analysis still types the first operand as_Nullable, so-Wnullable-to-nonnull-conversionis still triggered as a hard error under Xcode 26.4. Switch to the local-variable pattern that was already used correctly forRNTMyNativeViewCommon.mm:Changelog: [Internal]
Reviewed By: javache
Differential Revision: D101920741