Skip to content

Fix RCTTextLayoutManager nullable conversion (#56547) #56547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fkgozali wants to merge 1 commit into from
Closed

Fix RCTTextLayoutManager nullable conversion (#56547) #56547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...r/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextLayoutManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@ - (LinesMeasurements)getLinesForAttributedString:(facebook::react::AttributedStr
.width = usedRect.size.width, .height = usedRect.size.height}};

CGFloat baseline = [layoutManager locationForGlyphAtIndex:range.location].y;
const char *renderedUTF8 = [renderedString UTF8String];
auto line = LineMeasurement{
std::string(
[renderedString UTF8String] != nullptr ? [renderedString UTF8String] : ""),
std::string(renderedUTF8 != nullptr ? renderedUTF8 : ""),
rect,
overallRect.size.height - baseline,
font.capHeight,
Expand Down
Loading