[DevTools] Apply Activity slice filter when double clicking Activity #34908
+966
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
sebbie/10-17-_devtools_activity_slices
branch
from
83ee7f9 to
4c7ddf7
Compare
github-actions
bot
added
the
React Core Team
eps1lon
commented
Oct 19, 2025
| ▾ <Layout> | ||
| <Activity name="/blog"> | ||
| [suspense-root] rects={[{x:1,y:2,width:4,height:1}, {x:1,y:2,width:13,height:1}]} | ||
| <Suspense name="Unknown" rects={[{x:1,y:2,width:4,height:1}, {x:1,y:2,width:13,height:1}]}> |
There was a problem hiding this comment.
Name heuristic breaks once the Owner is filtered. Need to think about how to fix this. Only problematic when the Activity and Suspense share the same owner.
eps1lon
force-pushed
the
sebbie/10-17-_devtools_activity_slices
branch
from
0ab7239 to
fe34bef
Compare
eps1lon
changed the title
eps1lon
force-pushed
the
sebbie/10-17-_devtools_activity_slices
branch
2 times, most recently
from
1e3e641 to
ac9430f
Compare
Can be handled as a follow-up
eps1lon
force-pushed
the
sebbie/10-17-_devtools_activity_slices
branch
from
ac9430f to
f8d9db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34929
Initial idea was to just filter on the frontend but this is hard to do with the reliance on node weights for virtualization. Removing the part below the slice is trivial since that's just collapsing but the part above is harder.
This implements the slices with a backend filter. During reconciliation, we keep track on the stack whether we're in the Activity slice or not. Activity at the boundaries are included. That way you see which slice you're looking at and have affordances to navigate further down.
Will add the Activity pane to the Components tab in a follow-up. Double clicking an Activity already switches to the slice view. The Activity will not own any Components anyway.