Set default add_to_movie = 0.0001 #1534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #1533 - clarifies the behavior of
save_memmap
by pulling the 0.0001 that is currently added in almost all cases into the default value ofadd_to_movie
. See the issue page for more discussion - we are still considering adding more robust checks for negative or invalid values.Type of change
Please delete options that are not relevant.
Technically this could be a breaking change in 2 edge cases:
add_to_movie
; currently, 0.0001 will be added in addition to this value, whereas with this change the value will be used exactly. It probably will not make a difference in most cases and the current behavior is considered a bug.Has your PR been tested?
I did not run tests on this exact commit myself because I do not have the environment set up to use pytorch, but I did cherry-pick it onto main and run
caimanmanager test
, and all tests pass.