-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alignment invariant map to map distance #103
Conversation
Merge dev into main
merge dev into main
interim_y = np.asarray(centroids[:, 1] - rob[:, 1]) | ||
interim_z = np.asarray(centroids[:, 2] - rob[:, 2]) | ||
# magn = [np.linalg.norm(centroids[i, :] - rob[i, :]) for i in range(rob.shape[0])] | ||
# x = np.copy(interim_x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if I need this...
I resolved the issue with installing dask_hpc_runner, but had to remove support of python 3.8 and 3.9, since there were issues with the dask stuff. I added Python 3.12 and 3.13, and it passed all the tests! |
Could you add a config file example for this? Please include some comments explaining the parameters. I checked the one in the testing module, and the parameters are not very intuitive. Even better, it would be great if you could add a Pydantic config validator for this (check out my svd validator). The last part is not a priority, we should have an issue about writing all validators in Pydantic, we could do that then. |
Added a validator to gw_estra_params, and put in documentation in docstring |
Closes #96