Restore scalar code and improve portability #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DiamonDinoia
commented
Aug 20, 2025
DiamonDinoia
commented
- Reintroduce scalar code and add tests for vectorization
- Ensure xsimd compiles on unsupported platforms
- Add PPC support and dedicated workflow
Co-authored-by: Nils Wentzell <[email protected]>
- Simplifies and unifies CMake setup - Adds developer tools: cppcheck, IWYU, clang-tidy - Enables proper LTO support - Cleans and speeds up CI pipeline - Improves compatibility across Linux, Windows, and macOS - Updates dependencies and fixes MATLAB + CUDA integration - Removes reliance on MATLAB OpenMP, adjusts CUDA/MEX handling - Fixes various typos, warnings, and deployment target issues - Added fortran to CI
- Simplifies and unifies CMake setup - Adds developer tools: cppcheck, IWYU, clang-tidy - Enables proper LTO support - Cleans and speeds up CI pipeline - Improves compatibility across Linux, Windows, and macOS - Updates dependencies and fixes MATLAB + CUDA integration - Removes reliance on MATLAB OpenMP, adjusts CUDA/MEX handling - Fixes various typos, warnings, and deployment target issues # Conflicts: # CMakeLists.txt # cmake/toolchain.cmake
- Reintroduce scalar code and add tests for vectorization - Ensure xsimd compiles on unsupported platforms - Add PPC support and dedicated workflow
lu1and10
reviewed
Sep 4, 2025
|
|
||
| // 2D spread | ||
| { | ||
| BIGINT M = 32, N1 = 32, N2 = 16; |
There was a problem hiding this comment.
For double precision, having error message
"spreadcheck error: one or more non-trivial box dims is less than 2.nspread!
FINUFFT invokeGuru: setpts error (ier=3)!"
May need to increase N2 to 20 for current tol to avoid the error.
Test passes because err is Nan, comparing Nanif (err0 > thresh || err1 > thresh) gives false.
Need to check error code, i.e., ier = FINUFFT2D1... when setting fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.