-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Migrate the site infrastructure to Jaspr and Jaspr Content #12548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Visit the preview URL for this PR (updated for commit bb09726): https://flutter-docs-prod--pr12548-feat-jaspr-migration-kz7c0jfj.web.app |
|
@schultek Can you take a look at why the |
2614106 to
c247e2a
Compare
c247e2a to
5c6eefb
Compare
Migrate DartPad injection to Jaspr.
Migrates the `osSelector` shortcode and JS code to Jaspr. --------- Co-authored-by: Parker Lougheed <[email protected]>
Part of #12548 Migrates both the `app-figure.md` and `captioned-image.md` files to a `DashImage` Jaspr component.
Reorganizes the Jaspr components to the following: - Common components (Button, Card, etc) under `components/common` - @client components of these under `components/common/client` - Dartpad related under `components/dartpad` - Layout components (Header, Footer, SideNav, etc.) under `components/layout` - Page specific components (ArchiveTable, etc.) under `components/pages` Also cleans up the initialization of custom components for `jaspr_content`, by moving any attribute parsing logic to the respective component.
|
I'm playing with the staged site right next to the real site. I am on the desktop, not mobile. Overall, things look great! Observations:
My eyes need a break, but here's a few observations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with two asterisks
*I'm approving based on the code, independently of clicking through the staged site.
*I really only skimmed through it. From a high-level, it looks great, and I generally trust you two and don't feel the need to scrutinize every line. LMK if there's anything that you feel specifically you'd like eyeballs on.
Exciting!
|
Thank you both for taking a look and the feedback! Addressing each of the points raised by @sfshaza2 with resolutions and a few questions:
I've fixed this! Now the
The widget catalog pages happen to be pages where I turned off the TOC in this PR, so I believe this difference is to be expected. If you notice it elsewhere though, do please let me know :)
Nice catch. Fixed! Scrolling to the active entry in the sidenav should happen before page load finalizes now.
I see this inconsistent spacing on the old/live version but not on the new version. Does that match what you're seeing? If there's still an issue though, can you send a screenshot?
I can't seem to reproduce this. The fonts look the same when I overlay the pages. Can you try hard refreshing each page and let me know if you still notice differences? And send a screenshot of both. Thanks!
Good idea, thanks! I went ahead and did so and I fixed the one regression that came up as well as fixed a pre-existing issue. |
|
@parlough You asked us to point out pages with TOC differences other than the widget catalog, so while I'm 99% sure you already know this and it's probably expected, I'll do my due diligence and flag that I see the TOC missing on the new site's homepage, but present on the old site's homepage. |
Staged: https://flutter-docs-prod--pr12548-feat-jaspr-migration-kz7c0jfj.web.app/
Migrates the site from being built with JS/TS, Node, and 11ty to being built with purely Dart, Jaspr, and Jaspr Content.
As part of this work, the
dash_sitebash script has been removed from the root of the repository.After the removal, you can access the site tooling, including building and staging with
dart run dash_site <command>from anywhere within the repository workspace. If you still want a shorter command, you can add an alias fordart run dash_sitein your shell, such asdst.Staged: https://flutter-docs-prod--pr12548-feat-jaspr-migration-kz7c0jfj.web.app/
Resolves: #12405