Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for params having multiple values #681

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

badnikhil
Copy link
Contributor

@badnikhil badnikhil commented Mar 20, 2025

PR Description

The request parameters were previously handled as a Map<String, String>. I have updated this to Map<String, List<String>> (string,dyamic at many places) to support multiple values when needed. Additionally, I have modified the relevant implementations to accommodate this change.

Related Issues

Checklist

  • I have reviewed the contributing guide.
  • My branch is up to date and synced with the project's main branch before creating this PR.
  • I am using the latest stable Flutter version (flutter upgrade verified).
  • [] I have run all tests (flutter test), and they pass successfully.

Added/Updated Tests?

We encourage contributors to add relevant test cases.

  • Yes
  • No, because I plan to add tests after updating codegen for all supported languages.

Development & Testing Environment

  • Windows
  • Android
  • Linux

@badnikhil
Copy link
Contributor Author

badnikhil commented Mar 20, 2025

@ashitaprasad I am familiar with the codebase; however, I need to explore the test files further before making the necessary updates. I plan to work on that after updating codegen for all languages. In the meantime, please review the implementation and share your feedback.

@badnikhil badnikhil changed the title Resolve issue 166 support for params having multiple values Mar 20, 2025
@badnikhil badnikhil mentioned this pull request Mar 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not pass multiple query parameters with same key name
1 participant