Skip to content

refactor: Remove deprecated binlog endpoint#538

Merged
tanmoysrt merged 1 commit into
developfrom
remove_deprecated_endpoint
Jun 9, 2026
Merged

refactor: Remove deprecated binlog endpoint#538
tanmoysrt merged 1 commit into
developfrom
remove_deprecated_endpoint

Conversation

@tanmoysrt

Copy link
Copy Markdown
Member

In binlog v2, we have our custom indexer

In binlog v2, we have our custom indexer
@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the deprecated search_binary_log method and its corresponding /database/binary/logs/<log> endpoint, replaced by the binlog v2 custom indexer.

  • Deletes DatabaseServer.search_binary_log() from database_server.py, eliminating a shell-constructed mysqlbinlog command that passed user-supplied parameters directly into an f-string.
  • Removes the /database/binary/logs/<string:log> POST route from web.py.

Confidence Score: 5/5

Pure removal of a deprecated endpoint; no logic is changed, only deleted.

Only code that is deleted — no new paths, no side effects, no callers remain in the diff.

No files require special attention.

Important Files Changed

Filename Overview
agent/database_server.py Removes the deprecated search_binary_log method; no new code introduced.
agent/web.py Removes the /database/binary/logs/ POST route; no new code introduced.

Sequence Diagram

sequenceDiagram
    participant Client
    participant web.py
    participant DatabaseServer

    Note over Client,DatabaseServer: REMOVED in this PR
    Client->>web.py: "POST /database/binary/logs/{log}"
    web.py->>DatabaseServer: search_binary_log(log, database, ...)
    DatabaseServer->>DatabaseServer: build mysqlbinlog shell command (f-string)
    DatabaseServer-->>web.py: events[]
    web.py-->>Client: JSON response

    Note over Client,DatabaseServer: binlog v2 custom indexer handles this now
Loading

Reviews (1): Last reviewed commit: "refactor: Remove deprecated binlog endpo..." | Re-trigger Greptile

@tanmoysrt tanmoysrt merged commit c989154 into develop Jun 9, 2026
4 of 5 checks passed
@tanmoysrt tanmoysrt deleted the remove_deprecated_endpoint branch June 9, 2026 06:29
tanmoysrt added a commit that referenced this pull request Jun 9, 2026
refactor: Remove deprecated binlog endpoint (backport #538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant