Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: submit Interview Feedback using the Interview Feedback form #2929

Closed
wants to merge 1 commit into from

Conversation

asmitahase
Copy link
Collaborator

Problem

Child tables aren't configurable in dialogs because the schema is hardcoded, so users can't add any custom fields to such child tables.
We'll figure out a way to handle this in framework for now, refactoring the submit feedback button to direct to Interview feedback form instead of opening a dialog

Before

Screen.Recording.2025-03-31.at.7.45.27.PM.mov

After

Screen.Recording.2025-03-31.at.7.42.10.PM.mov

@ruchamahabal
Copy link
Member

I think this should be fixed in the framework directly instead of tweaking workflows here

@ankush
Copy link
Member

ankush commented Apr 1, 2025

@asmitahase @ruchamahabal you can use quick entry instead? A dialog will not support customization but quick entry is doable (since it's still backed by Meta).

Quick entry isn't perfect either but that's at least fixable/worth fixing.

@asmitahase
Copy link
Collaborator Author

Child tables aren't allowed in quick entry!

@ankush
Copy link
Member

ankush commented Apr 5, 2025

I don't know any valid reason for not doing that, maybe just figure out supporting child tables in quick entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants