refactor: submit Interview Feedback using the Interview Feedback form

hrms/hr/doctype/interview/interview.js

@@ -69,15 +69,9 @@ frappe.ui.form.on("Interview", {
 	},
 
 	submit_feedback: function (frm) {
-		frappe.call({
-			method: "hrms.hr.doctype.interview.interview.get_expected_skill_set",
-			args: {
-				interview_round: frm.doc.interview_round,
-			},
-			callback: function (r) {
-				frm.events.show_feedback_dialog(frm, r.message);
-				frm.refresh();
-			},
+		frappe.model.open_mapped_doc({
+			method: "hrms.hr.doctype.interview.interview.set_interview_feedback",
+			frm: frm,
 		});
 	},
 
@@ -126,78 +120,6 @@ frappe.ui.form.on("Interview", {
 		d.show();
 	},
 
-	show_feedback_dialog: function (frm, data) {
-		let fields = frm.events.get_fields_for_feedback();
-
-		let d = new frappe.ui.Dialog({
-			title: __("Submit Feedback"),
-			fields: [
-				{
-					fieldname: "skill_set",
-					fieldtype: "Table",
-					label: __("Skill Assessment"),
-					cannot_add_rows: false,
-					in_editable_grid: true,
-					reqd: 1,
-					fields: fields,
-					data: data,
-				},
-				{
-					fieldname: "result",
-					fieldtype: "Select",
-					options: ["", "Cleared", "Rejected"],
-					label: __("Result"),
-					reqd: 1,
-				},
-				{
-					fieldname: "feedback",
-					fieldtype: "Small Text",
-					label: __("Feedback"),
-				},
-			],
-			size: "large",
-			minimizable: true,
-			static: true,
-			primary_action: function (values) {
-				frappe
-					.call({
-						method: "hrms.hr.doctype.interview.interview.create_interview_feedback",
-						args: {
-							data: values,
-							interview_name: frm.doc.name,
-							interviewer: frappe.session.user,
-							job_applicant: frm.doc.job_applicant,
-						},
-					})
-					.then(() => {
-						frm.refresh();
-					});
-				d.hide();
-			},
-		});
-		d.show();
-		d.get_close_btn().show();
-	},
-
-	get_fields_for_feedback: function () {
-		return [
-			{
-				fieldtype: "Link",
-				fieldname: "skill",
-				options: "Skill",
-				in_list_view: 1,
-				label: __("Skill"),
-			},
-			{
-				fieldtype: "Rating",
-				fieldname: "rating",
-				label: __("Rating"),
-				in_list_view: 1,
-				reqd: 1,
-			},
-		];
-	},
-
 	interview_round: function (frm) {
 		frm.set_value("job_applicant", "");
 		frm.trigger("set_applicable_interviewers");

hrms/hr/doctype/interview/interview.py

@@ -7,6 +7,7 @@
 import frappe
 from frappe import _
 from frappe.model.document import Document
+from frappe.model.mapper import get_mapped_doc
 from frappe.query_builder.functions import Avg
 from frappe.utils import cint, cstr, get_datetime, get_link_to_form, getdate, nowtime
 
@@ -343,6 +344,33 @@ def create_interview_feedback(data, interview_name, interviewer, job_applicant):
 	)
 
 
+@frappe.whitelist()
+def set_interview_feedback(source, target=None):
+	def set_missing_values(source, target):
+		target.interviewer = frappe.session.user
+		skill_set = get_expected_skill_set(frappe.get_value("Interview", source, ["interview_round"]))
+		for skill in skill_set:
+			target.append("skill_assessment", skill)
+
+	interview_feedback = get_mapped_doc(
+		from_doctype="Interview",
+		from_docname=source,
+		table_maps={
+			"Interview": {
+				"doctype": "Interview Feedback",
+				"field_map": {
+					"interview": "name",
+					"interview_round": "interview_round",
+					"job_applicant": "job_applicant",
+				},
+			}
+		},
+		postprocess=set_missing_values,
+	)
+
+	return interview_feedback
+
+
 @frappe.whitelist()
 @frappe.validate_and_sanitize_search_inputs
 def get_interviewer_list(doctype, txt, searchfield, start, page_len, filters):