'Host group rules' > 'Settings' page #639
Merged
+101
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carma12
force-pushed
the
host-group-rules-settings
branch
from
484b779 to
89fa0b1
Compare
To prevent setting the functionality for the `Selector` component from PatternFly, the `BasicSelector` component must contain and isolate that functionality, as well as providing a reusable way of using it. Signed-off-by: Carla Martinez <[email protected]>
The `AutomemberUserRules` component can be used equally in 'User group rules' and 'Host group rules' pages. Based on that, the links to access the 'Settings' page should be different depending on which page is being accessed to. Signed-off-by: Carla Martinez <[email protected]>
The 'Host group rules' > 'Settings' page should show the information of a given automember entry. Signed-off-by: Carla Martinez <[email protected]>
As some components related to the automember section has multiple reusable components that can be used indistictively for `User group rules` and `Host group rules`, those can have a more generalistic name. Signed-off-by: Carla Martinez <[email protected]>
carma12
force-pushed
the
host-group-rules-settings
branch
from
89fa0b1 to
fa34d90
Compare
mreynolds389
approved these changes
Feb 20, 2025
|
Now we got both SimpleSelector and BasicSelector :( |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Host group rules' > 'Settings' page should show the information of a given automember entry.
This PR depends on this one to be merged: #637