Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transport Plotting GUI plugin #667

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Fix Transport Plotting GUI plugin #667

merged 3 commits into from
Mar 28, 2025

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 27, 2025

🦟 Bug fix

Summary

The transport gui plugin tool was broken by #583 as it mistakenly removed the PlottingIface object that's needed for QML -> C++ integration to work. This PR adds the variable back in the private implementation class.

Without the changes in this PR, when plotting a field from a topic, you'll see the following warning message in the console:

[warning] [Application.cc:915] [GUI] [QT] qrc:/qml/PlottingInterface.qml:114: ReferenceError: PlottingIface is not defined

To test

  1. Open Transport Plotting GUI plugin
  2. Open Topic Viewer plugin
  3. Try plotting any field from a topic
  4. Hit Play -> it should work now and you should see a line drawn on the graph

transport_plotting

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from jennuine as a code owner March 27, 2025 22:55
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Mar 27, 2025
iche033 added 2 commits March 27, 2025 23:06
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Mar 28, 2025
@iche033 iche033 merged commit d7d698b into main Mar 28, 2025
10 checks passed
@iche033 iche033 deleted the fix_transport_plotting branch March 28, 2025 17:09
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Mar 28, 2025
@iche033
Copy link
Contributor Author

iche033 commented Mar 28, 2025

@Mergifyio backport gz-gui9

Copy link

mergify bot commented Mar 28, 2025

backport gz-gui9

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 28, 2025
Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit d7d698b)
iche033 added a commit that referenced this pull request Mar 28, 2025
Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit d7d698b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants