Fix Transport Plotting GUI plugin (backport #667) #668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The transport gui plugin tool was broken by #583 as it mistakenly removed the
PlottingIface
object that's needed for QML -> C++ integration to work. This PR adds the variable back in the private implementation class.Without the changes in this PR, when plotting a field from a topic, you'll see the following warning message in the console:
To test
Transport Plotting
GUI pluginTopic Viewer
pluginChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.This is an automatic backport of pull request #667 done by [Mergify](https://mergify.com).