Add local memory cache to Redis implementation to reduce roundtrips #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
fedeazzato
previously approved these changes
Oct 20, 2025
Comment on lines
474
to
475
| if (_localCache != null) | ||
| _localCache.Set(cacheid, prefix, LocalCacheTTL(LOCAL_CACHE_PERSISTENT_KEY_TTL)); |
There was a problem hiding this comment.
You can use null conditional operator to combine the null check with the actual invocation. e.g.
_localCache?.Set(cacheid, prefix, LocalCacheTTL(LOCAL_CACHE_PERSISTENT_KEY_TTL));
There was a problem hiding this comment.
Similarly in other places it can be used as well in replacement of checking for non null, and then doing something with the field.
Comment on lines
-143
to
-152
| Task<bool> t = RedisDatabase.KeyExpireAsync(Key(cacheid, key), expiry, flags); | ||
| t.Wait(); | ||
| return t.Result; | ||
| string fullKey = Key(cacheid, key); | ||
| bool expirationSaved = RedisDatabase.KeyExpire(fullKey, expiry, flags); | ||
| if (expirationSaved) | ||
| KeyExpireLocal(fullKey); | ||
| return expirationSaved; | ||
| } | ||
|
|
||
| public bool KeyExists(string cacheid, string key) | ||
| { | ||
| Task<bool> t = RedisDatabase.KeyExistsAsync(Key(cacheid, key)); | ||
| t.Wait(); | ||
| return t.Result; |
There was a problem hiding this comment.
Nice fixing this async over sync when there was a sync API available!
| private void InitLocalCache() | ||
| { | ||
| #if NETCORE | ||
| if (EnvVarReader.GetEnvironmentValue(GXServices.CACHE_SERVICE, GXServices.REDIS_CACHE_SERVICE, "HYBRID", out string envVarValue) && envVarValue.Equals(true.ToString(), StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
This is extremely nitpick. Instead of true.ToString() you can use bool.TrueString which doesn't require creating a new string and is already interned.
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
had a problem deploying
to
external-storage-tests
GitHub Actions
Failure
Cherry pick to beta success |
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
Cherry pick to beta success |
…the default constructor used by CacheAPI.
claudiamurialdo
temporarily deployed
to
external-storage-tests
GitHub Actions
Inactive
claudiamurialdo
temporarily deployed
to
kafka-integration-tests
GitHub Actions
Inactive
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced an in-memory local cache in the Redis implementation to cache frequently accessed keys.
Issue:206738