Skip to content

Add local memory cache to Redis implementation to reduce roundtrips #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add local memory cache to Redis implementation to reduce roundtrips #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b922f6
Add local memory cache to Redis implementation to reduce roundtrips
Oct 20, 2025
f97a253
It seems better to keep GxRedis.cs unified for both .NET Framework an…
Oct 20, 2025
e46abf1
Applied Fazzato’s review suggestions
Oct 21, 2025
4ee1664
Fix build error.
Oct 21, 2025
39f8607
Read ENABLE_MEMORY_CACHE from provider settings and apply it only in …
Oct 22, 2025
f441cc9
Refactor local cache settings in Redis implementation to support conf…
Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions dotnet/src/dotnetcore/GxClasses/Services/Session/GXSessionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ public class GXSessionServiceFactory
private static readonly IGXLogger log = GXLoggerFactory.GetLogger<GXSessionServiceFactory>();

static ISessionService sessionService;
static string REDIS = "REDIS";
static string DATABASE = "DATABASE";
public static ISessionService GetProvider()
{
if (sessionService != null)
Expand All @@ -35,9 +33,9 @@ public static ISessionService GetProvider()
//Compatibility
if (string.IsNullOrEmpty(className))
{
if (providerService.Name.Equals(REDIS, StringComparison.OrdinalIgnoreCase))
if (providerService.Name.Equals(GXServices.REDIS_CACHE_SERVICE, StringComparison.OrdinalIgnoreCase))
type = typeof(GxRedisSession);
else if (providerService.Name.Equals(DATABASE, StringComparison.OrdinalIgnoreCase))
else if (providerService.Name.Equals(GXServices.DATABASE_CACHE_SERVICE, StringComparison.OrdinalIgnoreCase))
type = typeof(GxDatabaseSession);
}
else
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/dotnetcore/Providers/Cache/GxRedis/GxRedis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</PropertyGroup>

<ItemGroup>
<Compile Include="..\..\..\..\dotnetframework\Providers\Cache\GxRedis\GxRedis.cs" Link="GxRedis.cs" />
<Compile Include="..\..\..\..\dotnetframework\Providers\Cache\GxRedis\GxRedis.cs" Link="GxRedis.cs" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="StackExchange.Redis" Version="2.9.17" />
Expand Down
3 changes: 3 additions & 0 deletions dotnet/src/dotnetframework/GxClasses/Services/Storage/GXServices.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ public class GXServices
public static string STORAGE_SERVICE = "Storage";
public static string STORAGE_APISERVICE = "StorageAPI";
public static string CACHE_SERVICE = "Cache";
public static string REDIS_CACHE_SERVICE = "Redis";
public static string DATABASE_CACHE_SERVICE = "DATABASE";
public static string DATA_ACCESS_SERVICE = "DataAccess";
public static string SESSION_SERVICE = "Session";
public static string WEBNOTIFICATIONS_SERVICE = "WebNotifications";
Expand Down Expand Up @@ -47,6 +49,7 @@ public static GXServices Instance
}
set { }
}

public void AddService(string name, GXService service)
{
services[name] = service;
Expand Down
Loading
Loading