Skip to content

fixed missing typename keyword #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed missing typename keyword #1517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion loader/include/Geode/cocos/base_nodes/CCNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ class CC_DLL CCNode : public CCObject
// CCArrayExt is defined in geode/utils/cocos.hpp, which we cannot include due to circular includes.
// This is an incredibly hacky way to still be able to use the type

using CCArrayExt = geode::CCArrayExtCheck<T, PleaseDontChangeMe>::type;
using CCArrayExt = typename geode::CCArrayExtCheck<T, PleaseDontChangeMe>::type;
static_assert(!std::is_void_v<CCArrayExt>, "Please include <Geode/utils/cocos.hpp> to use getChildrenExt()");

return CCArrayExt(getChildren());
Expand Down
4 changes: 2 additions & 2 deletions loader/include/Geode/utils/Task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ namespace geode {
return {};
}

void return_base(MyTask::Type value) {
void return_base(typename MyTask::Type value) {
MyTask::finish(m_handle.lock(), std::move(value));
}

Expand Down Expand Up @@ -1094,7 +1094,7 @@ namespace geode {
);
}

Task<T, P>::Type await_resume() {
typename Task<T, P>::Type await_resume() {
return std::move(*task.getFinishedValue());
}
};
Expand Down