Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ReadTheDocs PR link automation #285

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Jan 3, 2025

Woops! 🔔

The automation is adding the following to every PR:

📚 Documentation preview: https://jupytergis--285.org.readthedocs.build/en/285/
💡 JupyterLite preview: {docs-pre-index-url}/lite

But it should look like:


📚 Documentation preview: https://jupytergis--285.org.readthedocs.build/en/285/
💡 JupyterLite preview: https://jupytergis--285.org.readthedocs.build/en/285/lite

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Binder 👈 Launch a Binder on branch geojupyter/jupytergis/fix-rtd-pr-link-typo

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Integration tests report: appsharing.space

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfisher87, LGTM

@brichet brichet merged commit b05567e into main Jan 6, 2025
18 checks passed
@mfisher87 mfisher87 deleted the fix-rtd-pr-link-typo branch January 6, 2025 16:57
@mfisher87
Copy link
Member Author

mfisher87 commented Jan 6, 2025

This did not resolve the issue. The action only supports one replacement because under the hood it's using JavaScript's String.replace method, which can only replace one occurrence. Modern versions of node support String.replaceAll.

image

readthedocs/actions#47

@brichet
Copy link
Collaborator

brichet commented Jan 7, 2025

Good catch.
Maybe we should remove the jupyterlite preview for now (it is still available in the doc), and open a issue to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants