Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lite Deployment Badge via RTD on PR using Custom Action #356

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Jan 17, 2025


Description

This fixes the lite badge on PR which now correctly redirects to Read the Docs lite deployment.

This was a nasty one!

All thanks to @mfisher87 for patching the GH action on his fork that we've been using 🚀

It has been tested on this PR on my fork

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--356.org.readthedocs.build/en/356/
💡 JupyterLite preview is available from the doc, by clicking on lite badge

---------

Co-authored-by: Matt Fisher <[email protected]>
Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/fix-rtd-badge

@arjxn-py arjxn-py added the documentation Improvements or additions to documentation label Jan 17, 2025
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Integration tests report: appsharing.space

@mfisher87
Copy link
Member

mfisher87 commented Jan 17, 2025

Lots of fun working with you this morning/evening ;) Thanks for your patience with me missing the obvious 🤣

Upstream PR: readthedocs/actions#48

Co-authored-by: Matt Fisher <[email protected]>
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@martinRenou martinRenou merged commit 2c62081 into geojupyter:main Jan 17, 2025
8 of 10 checks passed
@arjxn-py arjxn-py deleted the fix-rtd-badge branch January 20, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants