fix(feedback): last minute tweaks to apis to align implementation and docs #4873

armcknight · 2025-02-19T23:33:49Z

Fix a couple things I noticed while finalizing the docs PR: getsentry/sentry-docs#11191 and would like to fix before officially releasing the feature for the first time

#skip-changelog

codecov · 2025-02-19T23:39:56Z

Codecov Report

Attention: Patch coverage is 84.50704% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.193%. Comparing base (d33f2c8) to head (223474c).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...UserFeedback/SentryUserFeedbackFormViewModel.swift	50.000%	6 Missing ⚠️
...ift/Integrations/UserFeedback/SentryFeedback.swift	85.714%	2 Missing ⚠️
...rFeedback/SentryUserFeedbackWidgetButtonView.swift	0.000%	2 Missing ⚠️
Sources/Sentry/SentryClient.m	0.000%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4873       +/-   ##
=============================================
- Coverage   92.257%   92.193%   -0.064%     
=============================================
  Files          659       659               
  Lines        77310     77527      +217     
  Branches     27933     27281      -652     
=============================================
+ Hits         71324     71475      +151     
- Misses        5890      5960       +70     
+ Partials        96        92        -4

Files with missing lines	Coverage Δ
Sources/Sentry/SentrySDK.m	`88.288% <ø> (+0.674%)`	⬆️
...onfiguration/SentryUserFeedbackConfiguration.swift	`53.333% <ø> (-1.506%)`	⬇️
...guration/SentryUserFeedbackFormConfiguration.swift	`100.000% <100.000%> (ø)`
...uration/SentryUserFeedbackThemeConfiguration.swift	`82.352% <100.000%> (ø)`
...ts/Integrations/Feedback/SentryFeedbackTests.swift	`97.633% <100.000%> (+0.531%)`	⬆️
Sources/Sentry/SentryClient.m	`95.184% <0.000%> (ø)`
...ift/Integrations/UserFeedback/SentryFeedback.swift	`72.727% <85.714%> (+5.380%)`	⬆️
...rFeedback/SentryUserFeedbackWidgetButtonView.swift	`0.000% <0.000%> (ø)`
...UserFeedback/SentryUserFeedbackFormViewModel.swift	`84.634% <50.000%> (-0.726%)`	⬇️

... and 33 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d33f2c8...223474c. Read the comment docs.

github-actions · 2025-02-19T23:45:18Z

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1233.73 ms	1247.82 ms	14.08 ms
Size	22.31 KiB	822.17 KiB	799.87 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7fb7afb`	1230.12 ms	1251.04 ms	20.92 ms
`b8dd0fc`	1268.96 ms	1271.90 ms	2.94 ms
`2b19b82`	1237.45 ms	1256.60 ms	19.16 ms
`c76f9b0`	1249.78 ms	1265.14 ms	15.36 ms
`e8b2fb4`	1230.70 ms	1242.84 ms	12.14 ms
`bee3e88`	1232.65 ms	1247.33 ms	14.68 ms
`2862f33`	1208.83 ms	1227.29 ms	18.45 ms
`5d6ce0e`	1206.72 ms	1228.67 ms	21.95 ms
`aa27ac0`	1214.02 ms	1227.42 ms	13.40 ms
`eae2b59`	1229.62 ms	1251.83 ms	22.21 ms

App size

Revision	Plain	With Sentry	Diff
`7fb7afb`	20.76 KiB	419.70 KiB	398.94 KiB
`b8dd0fc`	20.76 KiB	401.39 KiB	380.63 KiB
`2b19b82`	21.58 KiB	542.19 KiB	520.61 KiB
`c76f9b0`	22.85 KiB	406.69 KiB	383.84 KiB
`e8b2fb4`	20.76 KiB	427.23 KiB	406.46 KiB
`bee3e88`	22.30 KiB	749.95 KiB	727.64 KiB
`2862f33`	22.31 KiB	775.17 KiB	752.86 KiB
`5d6ce0e`	22.85 KiB	405.38 KiB	382.53 KiB
`aa27ac0`	20.76 KiB	432.21 KiB	411.45 KiB
`eae2b59`	21.58 KiB	705.31 KiB	683.72 KiB

Previous results on branch: armcknight/feat(feedback)/final-fixes

Startup times

Revision	Plain	With Sentry	Diff
`5baa4a5`	1227.49 ms	1245.43 ms	17.94 ms
`f09e892`	1220.22 ms	1238.80 ms	18.57 ms
`cc14e49`	1209.31 ms	1231.54 ms	22.24 ms
`38ae188`	1221.04 ms	1246.91 ms	25.87 ms

App size

Revision	Plain	With Sentry	Diff
`5baa4a5`	22.31 KiB	821.57 KiB	799.26 KiB
`f09e892`	22.31 KiB	820.98 KiB	798.67 KiB
`cc14e49`	22.31 KiB	821.57 KiB	799.26 KiB
`38ae188`	22.31 KiB	820.94 KiB	798.63 KiB

…sibilities

Sources/Swift/Integrations/UserFeedback/SentryFeedback.swift

Sources/Swift/Integrations/UserFeedback/SentryUserFeedbackFormViewModel.swift

Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackFormConfiguration.swift

...ces/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackThemeConfiguration.swift

bruno-garcia

I made it 50% of the PR, only 1 question

Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackConfiguration.swift

philprime

Left a couple of comments, but other than that LGTM

philprime · 2025-02-21T09:54:17Z

Sources/Swift/Integrations/UserFeedback/SentryFeedback.swift

        }
-        dict["source"] = source.rawValue
+        dict["source"] = source.description


l: See my comment in #4874

#4874 (comment)

philprime · 2025-02-21T09:55:42Z

Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift

+        let sut = SentryFeedback(message: "Test feedback message", name: "Test feedback provider", email: "[email protected]", source: .custom, attachments: [Data()])
+
+        let serialization = sut.serialize()
+        XCTAssertEqual(try XCTUnwrap(serialization["message"] as? String), "Test feedback message")


l: see my comment in #4784

#4874 (comment)

philipphofmann

LGTM, with a few suggestions.

philipphofmann · 2025-02-21T15:25:23Z

Samples/iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift

@@ -248,7 +246,7 @@ extension UserFeedbackUITests {
        try assertHookMarkersNotExist()

        widgetButton.tap()
-
+        XCTAssert(sendButton.waitForExistence(timeout: 1))


m: Any reason why we can't use waitForExistence

sentry-cocoa/Samples/iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift

Lines 4 to 6 in 25f4e43

func waitForExistence(_ message: String) {

XCTAssertTrue(self.waitForExistence(timeout: TimeInterval(10)), message)

}

philipphofmann · 2025-02-21T15:26:38Z

Sources/Sentry/SentryClient.m

@@ -617,7 +617,7 @@ - (void)captureFeedback:(SentryFeedback *)feedback withScope:(SentryScope *)scop
                             alwaysAttachStacktrace:NO];
    SentryTraceContext *traceContext = [self getTraceStateWithEvent:preparedEvent withScope:scope];
    NSArray *attachments = [[self attachmentsForEvent:preparedEvent scope:scope]
-        arrayByAddingObjectsFromArray:[feedback attachments]];
+        arrayByAddingObjectsFromArray:[feedback attachmentsForEnvelope]];


m: If this is a bug, it would be valuable to add a test for this or to assert for the correct attachments in an existing test to avoid having the same issue in the future.

Nope, it was due to the rename I mentioned in #4873 (comment). There are a couple test cases that check at least for its presence:

sentry-cocoa/Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift

Lines 31 to 90 in cd24266

func testSerializeWithAllFields() throws {

let sut = SentryFeedback(message: "Test feedback message", name: "Test feedback provider", email: "[email protected]", screenshot: Data())

let serialization = sut.serialize()

XCTAssertEqual(try XCTUnwrap(serialization["message"] as? String), "Test feedback message")

XCTAssertEqual(try XCTUnwrap(serialization["name"] as? String), "Test feedback provider")

XCTAssertEqual(try XCTUnwrap(serialization["contact_email"] as? String), "[email protected]")

XCTAssertEqual(try XCTUnwrap(serialization["source"] as? String), "widget")

let attachments = sut.attachments()

XCTAssertEqual(attachments.count, 1)

XCTAssertEqual(try XCTUnwrap(attachments.first).filename, "screenshot.png")

XCTAssertEqual(try XCTUnwrap(attachments.first).contentType, "application/png")

}

func testSerializeWithNoOptionalFields() throws {

let sut = SentryFeedback(message: "Test feedback message", name: nil, email: nil)

let serialization = sut.serialize()

XCTAssertEqual(try XCTUnwrap(serialization["message"] as? String), "Test feedback message")

XCTAssertNil(serialization["name"])

XCTAssertNil(serialization["contact_email"])

XCTAssertEqual(try XCTUnwrap(serialization["source"] as? String), "widget")

let attachments = sut.attachments()

XCTAssertEqual(attachments.count, 0)

}

private let inputCombinations: [FeedbackTestCase] = [

// base case: don't require name or email, don't input a name or email, don't input a message or screenshot

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

// set a screenshot

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

// set a message

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name or email address with message: Test message."),

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name or email address including attached screenshot with message: Test message."),

// set an email address

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] with message: Test message."),

(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] including attached screenshot with message: Test message."),

// set a name

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester with no email address with message: Test message."),

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester with no email address including attached screenshot with message: Test message."),

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester at [email protected] with message: Test message."),

(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester at [email protected] including attached screenshot with message: Test message."),

// require email address

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following fields: email and description."),

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following fields: email and description."),

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: email."),

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: email."),

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] with message: Test message."),

(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] including attached screenshot with message: Test message."),

(config: (requiresName: false, requiresEmail: true, nameInput: "tester", emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following fields: email and description."),

I added a ui test to check the envelope contents for the attachments in 7678e18

Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackConfiguration.swift

philipphofmann · 2025-02-21T15:35:33Z

Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackFormConfiguration.swift

+     * Sets the email and name field text content to `SentryUser.email` and `SentryUser.name`.
+     * - note: Default: `true`
+     */
+    public var useSentryUser: Bool = true


m: What about useScopeUser? I mean it's not the Sentry user but the user form the scope.

Hmm, is there ever a user object besides what's stored in the scope? For reference, here's the doc for this: https://github.com/getsentry/sentry-docs/pull/11191/files#diff-d02ef3c10131140fde283da64efeebe4d40068d0fbb2ebc610be2377571b7ad4R89

I don't want to change the name because this is what it's called in other SDKs. But I can improve the headerdoc here to indicate it comes from the current scope's user.

it was making a 2d array

WIP: last minute tweaks to apis to align implementation and docs

165e716

armcknight requested review from philipphofmann and philprime as code owners February 19, 2025 23:33

armcknight mentioned this pull request Feb 19, 2025

feedback: First shipment to public as early access / beta #4709

Open

5 tasks

armcknight and others added 7 commits February 19, 2025 17:44

WIP: we need to make these changes in the public release pr

ec5c3cd

change the init parameter to be more generic for future expansion pos…

601febe

…sibilities

Format code

c0c3421

use SentryId instead of String

b4f5b1b

followups

2ef90a3

Format code

125bbcf

fix test failure and add some missing ones

c012ee6

armcknight marked this pull request as draft February 20, 2025 08:31

armcknight marked this pull request as ready for review February 20, 2025 17:47

actually these will need to be accessible from other sdk code and tests

a36c160

armcknight commented Feb 20, 2025

View reviewed changes

armcknight mentioned this pull request Feb 20, 2025

Cocoa User Feedback getsentry/sentry-docs#11191

Open

7 tasks

bruno-garcia reviewed Feb 20, 2025

View reviewed changes

Sources/Swift/Integrations/UserFeedback/Configuration/SentryUserFeedbackConfiguration.swift Show resolved Hide resolved

armcknight added 2 commits February 20, 2025 14:37

try to fix timing issue on ui test

e5ddb14

remove unimplemented additional trigger (added to ticket)

b7e9b56

philprime approved these changes Feb 21, 2025

View reviewed changes

philipphofmann approved these changes Feb 21, 2025

View reviewed changes

This was referenced Feb 21, 2025

feedback: automatically provide SentryUser info to SentrySDK.captureFeedback function #4884

Open

feedback: success/confirmation #4885

Open

armcknight added 3 commits February 21, 2025 11:28

forgot to change this to accomodate the new array type

aa7cc03

it was making a 2d array

add feedback attachment verification to ui tests

7678e18

forgot to remove this after removing SentrySDK.showFeedbackForm

223474c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(feedback): last minute tweaks to apis to align implementation and docs #4873

fix(feedback): last minute tweaks to apis to align implementation and docs #4873

armcknight commented Feb 19, 2025 •

edited

Loading

codecov bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: armcknight/feat(feedback)/final-fixes

Startup times

App size

bruno-garcia left a comment

philprime left a comment

philprime Feb 21, 2025

philprime Feb 21, 2025

philipphofmann left a comment

philipphofmann Feb 21, 2025

philipphofmann Feb 21, 2025

armcknight Feb 21, 2025

philipphofmann Feb 21, 2025

armcknight Feb 21, 2025

	func waitForExistence(_ message: String) {
	XCTAssertTrue(self.waitForExistence(timeout: TimeInterval(10)), message)
	}

	func testSerializeWithAllFields() throws {
	let sut = SentryFeedback(message: "Test feedback message", name: "Test feedback provider", email: "[email protected]", screenshot: Data())

	let serialization = sut.serialize()
	XCTAssertEqual(try XCTUnwrap(serialization["message"] as? String), "Test feedback message")
	XCTAssertEqual(try XCTUnwrap(serialization["name"] as? String), "Test feedback provider")
	XCTAssertEqual(try XCTUnwrap(serialization["contact_email"] as? String), "[email protected]")
	XCTAssertEqual(try XCTUnwrap(serialization["source"] as? String), "widget")

	let attachments = sut.attachments()
	XCTAssertEqual(attachments.count, 1)
	XCTAssertEqual(try XCTUnwrap(attachments.first).filename, "screenshot.png")
	XCTAssertEqual(try XCTUnwrap(attachments.first).contentType, "application/png")
	}

	func testSerializeWithNoOptionalFields() throws {
	let sut = SentryFeedback(message: "Test feedback message", name: nil, email: nil)

	let serialization = sut.serialize()
	XCTAssertEqual(try XCTUnwrap(serialization["message"] as? String), "Test feedback message")
	XCTAssertNil(serialization["name"])
	XCTAssertNil(serialization["contact_email"])
	XCTAssertEqual(try XCTUnwrap(serialization["source"] as? String), "widget")

	let attachments = sut.attachments()
	XCTAssertEqual(attachments.count, 0)
	}

	private let inputCombinations: [FeedbackTestCase] = [
	// base case: don't require name or email, don't input a name or email, don't input a message or screenshot
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	// set a screenshot
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	// set a message
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name or email address with message: Test message."),
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name or email address including attached screenshot with message: Test message."),
	// set an email address
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] with message: Test message."),
	(config: (requiresName: false, requiresEmail: false, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] including attached screenshot with message: Test message."),
	// set a name
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester with no email address with message: Test message."),
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: nil, messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester with no email address including attached screenshot with message: Test message."),
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester at [email protected] with message: Test message."),
	(config: (requiresName: false, requiresEmail: false, nameInput: "tester", emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback for tester at [email protected] including attached screenshot with message: Test message."),
	// require email address
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following fields: email and description."),
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following fields: email and description."),
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: email."),
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: nil, messageInput: "Test message", includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: email."),
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: nil, includeScreenshot: true), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following field: description."),
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: false), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] with message: Test message."),
	(config: (requiresName: false, requiresEmail: true, nameInput: nil, emailInput: "[email protected]", messageInput: "Test message", includeScreenshot: true), shouldValidate: true, expectedSubmitButtonAccessibilityHint: "Will submit feedback with no name at [email protected] including attached screenshot with message: Test message."),
	(config: (requiresName: false, requiresEmail: true, nameInput: "tester", emailInput: nil, messageInput: nil, includeScreenshot: false), shouldValidate: false, expectedSubmitButtonAccessibilityHint: "You must provide all required information before submitting. Please check the following fields: email and description."),

fix(feedback): last minute tweaks to apis to align implementation and docs #4873

Are you sure you want to change the base?

fix(feedback): last minute tweaks to apis to align implementation and docs #4873

Conversation

armcknight commented Feb 19, 2025 • edited Loading

codecov bot commented Feb 19, 2025 • edited Loading

Codecov Report

github-actions bot commented Feb 19, 2025 • edited Loading

Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: armcknight/feat(feedback)/final-fixes

Startup times

App size

bruno-garcia left a comment

Choose a reason for hiding this comment

philprime left a comment

Choose a reason for hiding this comment

philprime Feb 21, 2025

Choose a reason for hiding this comment

philprime Feb 21, 2025

Choose a reason for hiding this comment

philipphofmann left a comment

Choose a reason for hiding this comment

philipphofmann Feb 21, 2025

Choose a reason for hiding this comment

philipphofmann Feb 21, 2025

Choose a reason for hiding this comment

armcknight Feb 21, 2025

Choose a reason for hiding this comment

philipphofmann Feb 21, 2025

Choose a reason for hiding this comment

armcknight Feb 21, 2025

Choose a reason for hiding this comment

armcknight commented Feb 19, 2025 •

edited

Loading

codecov bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading