-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cocoa User Feedback #11191
base: master
Are you sure you want to change the base?
Cocoa User Feedback #11191
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 225 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding!
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @coolguyzone , sorry I missed your message. Yes, I'm preparing to merge this PR now. |
…r-feedback)/cocoa-docs
…r-feedback)/cocoa-docs
@armcknight closed/reopen to see if Vercel runs another build. The current one seems expired |
@bruno-garcia Finally got it working again, here are the relevant pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Super thorough.
One small fix suggested (static API used is JS -> Swift).
Didn't see any migration doc, do we need one from SentryUserFeedback
to SentryFeedback
? Possibly a good follow up PR to get ppl to move to the new API.
https://sentry-docs-git-armcknight-featuser-feedbackcocoa-docs.sentry.dev/platforms/apple/migration/
Not a problem with this PR but something we need to look at, the table rendering:
@coolguyzone something you can help us with?
docs/platforms/apple/common/user-feedback/configuration/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Bruno Garcia <[email protected]>
Pushed a small change to your table so it stops overflowing! |
Thanks @chargome! FYI to all, I'm waiting to merge this PR until getsentry/sentry-cocoa#4873 is approved, so we have alignment between the docs and implementation. |
DESCRIBE YOUR PR
Documents a new feature for gathering User Feedback in a Cocoa app, based on the similar feature we already ship in e.g. sentry-javascript. Used https://docs.sentry.io/platforms/javascript/user-feedback/ as inspiration.
sentry-cocoa PR that declares the API: getsentry/sentry-cocoa#4284; tracking work at getsentry/sentry-cocoa#4269
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES