-
-
Notifications
You must be signed in to change notification settings - Fork 372
chore: Ensure simctl's dyld shared cache is updated #6723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6723 +/- ##
=============================================
+ Coverage 85.102% 85.134% +0.032%
=============================================
Files 452 453 +1
Lines 27683 27689 +6
Branches 12125 12109 -16
=============================================
+ Hits 23559 23573 +14
+ Misses 4076 4068 -8
Partials 48 48 see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 707c222 | 1223.06 ms | 1260.67 ms | 37.61 ms |
| 5200f5b | 1231.73 ms | 1254.35 ms | 22.62 ms |
| ea12acf | 1217.67 ms | 1252.69 ms | 35.03 ms |
| 005f255 | 1218.42 ms | 1247.09 ms | 28.67 ms |
| 2137530 | 1223.39 ms | 1253.25 ms | 29.86 ms |
| ad964ca | 1234.73 ms | 1254.88 ms | 20.15 ms |
| 3cdbc22 | 1231.63 ms | 1251.06 ms | 19.43 ms |
| 11853e6 | 1220.37 ms | 1252.83 ms | 32.46 ms |
| d72784d | 1214.31 ms | 1241.35 ms | 27.04 ms |
| 324c109 | 1228.35 ms | 1252.47 ms | 24.12 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 707c222 | 23.75 KiB | 1.00 MiB | 1005.07 KiB |
| 5200f5b | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| ea12acf | 23.75 KiB | 974.89 KiB | 951.14 KiB |
| 005f255 | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| 2137530 | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| ad964ca | 23.75 KiB | 913.17 KiB | 889.42 KiB |
| 3cdbc22 | 23.75 KiB | 928.14 KiB | 904.40 KiB |
| 11853e6 | 23.75 KiB | 1.01 MiB | 1016.04 KiB |
| d72784d | 23.75 KiB | 988.01 KiB | 964.27 KiB |
| 324c109 | 23.75 KiB | 919.91 KiB | 896.16 KiB |
Previous results on branch: itay/ensure_simulators_are_initialized
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b8ab9d1 | 1198.21 ms | 1217.04 ms | 18.83 ms |
| 381c83e | 1210.52 ms | 1239.94 ms | 29.42 ms |
| 268b519 | 1221.38 ms | 1252.74 ms | 31.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b8ab9d1 | 24.15 KiB | 1023.19 KiB | 999.04 KiB |
| 381c83e | 23.75 KiB | 1.00 MiB | 1001.51 KiB |
| 268b519 | 24.15 KiB | 1023.17 KiB | 999.02 KiB |
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
| xcrun simctl list devices | ||
| - name: Install Rosetta | ||
| run: softwareupdate --install-rosetta --agree-to-license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should already be installed on Cirrus Runenrs
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
|
|
||
| - name: Install Rosetta | ||
| run: | | ||
| xcrun simctl list runtimes -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Rosetta installation step is incomplete.
The "Install Rosetta" step doesn't actually install Rosetta - it only lists runtimes via xcrun simctl list runtimes -v. In contrast, unit-test-common.yml correctly installs Rosetta using softwareupdate --install-rosetta --agree-to-license. This will cause failures on standard GitHub runners where Rosetta isn't pre-installed.
Some UI tests may be failing due to the iOS simulator not being properly loaded.
This is a know issue in Xcode 26.1: https://developer.apple.com/documentation/xcode-release-notes/xcode-26_1-release-notes#Known-Issues