Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/file-filters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ run_unit_tests_for_prs: &run_unit_tests_for_prs

# GH Actions
- ".github/workflows/test.yml"
- ".github/workflows/unit-test-common.yml"
- ".github/file-filters.yml"

# Scripts
Expand Down
15 changes: 14 additions & 1 deletion .github/workflows/ui-tests-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ on:

jobs:
common-ui-tests:
if: ${{ !inputs.should_skip }}
# test in cirrus labs
# if: ${{ !inputs.should_skip }}
name: UI Tests Common
runs-on: ${{ inputs.run_on_cirrus_labs && fromJSON(format('["ghcr.io/cirruslabs/macos-runner:{0}", "runner_group_id:10"]', inputs.macos_version)) || inputs.macos_version }}
timeout-minutes: 40
Expand Down Expand Up @@ -109,6 +110,18 @@ jobs:
OS_VERSION: ${{ inputs.test-destination-os }}
run: ./scripts/ci-install-platforms.sh --platforms "$PLATFORM" --os-version "$OS_VERSION"

- name: Install Rosetta
run: |
xcrun simctl list runtimes -v
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Rosetta installation step is incomplete.

The "Install Rosetta" step doesn't actually install Rosetta - it only lists runtimes via xcrun simctl list runtimes -v. In contrast, unit-test-common.yml correctly installs Rosetta using softwareupdate --install-rosetta --agree-to-license. This will cause failures on standard GitHub runners where Rosetta isn't pre-installed.

Fix in Cursor Fix in Web


- name: Ensure simctl dyld shared cache is updated
# Xcode 15.x doesn't support this command, so we skip it for that version.
if: ${{ !contains(inputs.xcode_version, '15.') }}
run: |
xcrun simctl runtime dyld_shared_cache update --all
xcrun simctl list runtimes -v
xcrun simctl list devices

- name: Create simulator device
if: ${{ inputs.create_device }}
env:
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/unit-test-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,19 @@ jobs:
if: ${{ inputs.install_platforms }}
run: ./scripts/ci-install-platforms.sh --platforms "${{ inputs.platform }}" --os-version "${{ inputs.test-destination-os }}"

- name: Install Rosetta
run: |
xcrun simctl list runtimes -v
softwareupdate --install-rosetta --agree-to-license

- name: Ensure simctl dyld shared cache is updated
# Xcode 15.x doesn't support this command, so we skip it for that version.
if: ${{ !contains(inputs.xcode, '15.') }}
run: |
xcrun simctl runtime dyld_shared_cache update --all
xcrun simctl list runtimes -v
xcrun simctl list devices

# Create simulator devices for non-preinstalled simulators
# Required for iOS 16.4, iOS 17.5 (on Xcode 15.4), and iOS/tvOS 26.1
- name: Create simulator device
Expand Down
Loading