ref(skills): retire sentry-setup-ai-monitoring into sentry-instrument#286
Open
evanpurkhiser wants to merge 1 commit into
Open
Conversation
AI/LLM monitoring is a signal, and sentry-instrument already wires it up per platform from the reference library. With the shared concepts/ai-monitoring.md now in place (#285) as the canonical home for the cross-cutting rules — gen_ai.* model, conversation-ID format, token/cost accounting, PII and sampling strategy — the standalone skill is fully absorbed. Remove sentry-setup-ai-monitoring: drop the skill, its entry and AI wording in the sentry-feature-setup router, and the README/AGENTS listings, then regenerate SKILL_TREE.md.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-skills-retire-sentry-setup-ai-monitoring-into-sentry-instrument
branch
from
9bb26ce to
b7d2950
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| @@ -49,5 +49,4 @@ Configure specific Sentry capabilities beyond basic SDK setup. | |||
| |---|---| | |||
| | Create Sentry alerts using the workflow engine API | [`sentry-create-alert`](skills/sentry-create-alert/SKILL.md) | | |||
There was a problem hiding this comment.
Bug: The PR removes the sentry-setup-ai-monitoring skill, but legacy skill files in skills-legacy/ still contain broken references to it and its deleted sampling.md guide.
Severity: MEDIUM
Suggested Fix
Update the files in the skills-legacy/ directory to remove or replace the references to the deleted sentry-setup-ai-monitoring skill and its associated sampling.md file. Either point them to the new, correct skill and documentation or remove the feature reference if it's no longer supported in the legacy context. Consider adding the skills-legacy/ directory to the build validation script to prevent future issues.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/SKILL_TREE.md#L50
Potential issue: The pull request retires the `sentry-setup-ai-monitoring` skill but
fails to update references in several legacy skill files located in the `skills-legacy/`
directory. Specifically, files like `skills-legacy/sentry-node-sdk/SKILL.md` and
`skills-legacy/sentry-instrumentation-guide/SKILL.md` still direct users to load the
now-deleted skill. Additionally, multiple legacy `ai-monitoring.md` reference files
contain broken links to a deleted `sampling.md` guide. Because the build validation
script ignores the `skills-legacy/` directory, these broken references were not caught,
which will lead to user confusion, routing failures, and 404 errors for users accessing
this legacy documentation.
Also affects:
skills-legacy/sentry-python-sdk/references/ai-monitoring.md:312skills-legacy/sentry-node-sdk/references/ai-monitoring.md:229skills-legacy/sentry-nextjs-sdk/references/ai-monitoring.md:421skills-legacy/sentry-nestjs-sdk/references/ai-monitoring.md:336skills-legacy/sentry-node-sdk/SKILL.md:680skills-legacy/sentry-instrumentation-guide/SKILL.md:125
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #285. AI/LLM monitoring is a signal, and
sentry-instrumentalready wires it up per platform from the reference library. Now that #285 landed the sharedconcepts/ai-monitoring.mdas the canonical home for the cross-cutting rules (thegen_ai.*model, conversation-ID format, token/cost accounting, and PII/sampling strategy), the standalonesentry-setup-ai-monitoringskill is fully absorbed and safe to remove.This drops the skill, its entry and AI wording in the
sentry-feature-setuprouter, and the README/AGENTS listings, then regeneratesSKILL_TREE.md. Thesentry-instrumentdescription gains the provider names (OpenAI, Anthropic, Vercel AI, LangChain, Google GenAI) so intent-matching stays as sharp as the retired skill's description.Verified
build-skill-tree.sh --checkpasses and hydration produces no warnings. Note: this and #283 both regenerateSKILL_TREE.md, so whichever merges second will need a trivial regen of that generated file.