Skip to content

chore(tests): Address flakiness on eco-related tests #94869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Jul 3, 2025

tests/sentry/integrations/gitlab/tasks/test_pr_comment.py::TestCommentWorkflow::test_comment_workflow_updates_comment
tests/sentry/integrations/github/tasks/test_pr_comment.py::TestCommentWorkflow::test_comment_workflow_updates_comment
  • These tests were recently modified, and I haven't been able to reproduce the flakes

tests/sentry_plugins/twilio/test_plugin.py::test_entry_point
  • Doesn't appear to be test related, but will monitor

tests/acceptance/test_link_team.py::SlackLinkTeamTest::test_link_team
tests/acceptance/test_link_team.py::SlackLinkTeamTest::test_link_team_as_team_admin
  • The flakiness was a race, addressed by waiting for the next page to load

tests/sentry_plugins/test_anonymizeip.py::test_ipv6
tests/sentry/integrations/utils/test_scope.py::BindOrgContextFromIntegrationTest__InControlMode::test_binds_org_context_with_multiple_orgs
tests/sentry/integrations/github/test_webhooks.py::PullRequestEventWebhook::test_multiple_orgs_creates_missing_repo
tests/sentry/integrations/github/tasks/test_open_pr_comment.py::TestOpenPRCommentWorkflow::test_comment_workflow
tests/sentry/tasks/test_daily_summary.py::DailySummaryTest::test_no_performance_issues
tests/sentry_plugins/victorops/test_plugin.py::test_entry_point
tests/sentry/integrations/utils/test_scope.py::BindOrgContextFromIntegrationTest__InRegionMode::test_binds_org_context_with_multiple_orgs
tests/sentry/integrations/opsgenie/test_integration.py::OpsgenieMigrationIntegrationTest::test_migrate_plugin


tests/sentry/integrations/slack/webhooks/actions/test_status.py::StatusActionTest::test_permission_denied
tests/sentry/integrations/slack/webhooks/actions/test_status.py::StatusActionTest::test_permission_denied_through_unfurl
tests/sentry/integrations/slack/webhooks/actions/test_status.py::StatusActionTest::test_archive_issue_until_escalating
  • The URLs built from these webhooks have signed parameters which use TimestampSigner. If the timestamp changes between between test and implementation, a flake is produced. freeze_time prevented this.

tests/acceptance/chartcuterie/test_chart_renderer.py::TestChartRenderer::test_debug_renders
tests/acceptance/chartcuterie/test_image_block_builder.py::TestSlackImageBlockBuilder::test_image_block_for_function_regression
tests/acceptance/chartcuterie/test_image_block_builder.py::TestSlackImageBlockBuilder::test_image_not_generated_for_unsupported_issues
  • 🚧 working on these

tests/acceptance/sentry_plugins/test_amazon_sqs.py::AmazonSQSTest::test_simple
tests/jobs/test_onboardingtasks_split_into_specific_integrations.py::OnboardingTasksSplitIntoSpecificIntegrationsTest::test_get_items
tests/sentry/integrations/utils/test_scope.py::BindOrgContextFromIntegrationTest::test_binds_org_context_with_multiple_orgs


@leeandher leeandher requested a review from a team July 3, 2025 15:15
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 3, 2025
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #94869      +/-   ##
==========================================
+ Coverage   84.18%   87.89%   +3.71%     
==========================================
  Files       10437    10442       +5     
  Lines      603405   604003     +598     
  Branches    23501    23501              
==========================================
+ Hits       507961   530883   +22922     
+ Misses      95078    72754   -22324     
  Partials      366      366              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant