getsentry · leeandher · Jul 3, 2025 · Jul 3, 2025 · Jul 3, 2025 · Jul 4, 2025
@@ -11,7 +11,6 @@
 
 
 def build_linking_url(endpoint: str, **kwargs: Any) -> str:
-    """TODO(mgaeta): Remove cast once sentry/utils/http.py is typed."""
     url: str = absolute_uri(reverse(endpoint, kwargs={"signed_params": sign(salt=SALT, **kwargs)}))
     return url
 

diff --git a/src/sentry/templates/sentry/integrations/slack/post-linked-team.html b/src/sentry/templates/sentry/integrations/slack/post-linked-team.html
@@ -11,7 +11,7 @@
       {% trans body_text %}
     </p>
     <p>
-      <a href="slack://channel?id={{ channel_id }}&team={{ team_id }}" class="btn btn-default btn-login-slack">
+      <a href="slack://channel?id={{ channel_id }}&team={{ team_id }}" class="btn btn-default btn-login-slack" data-test-id="back-to-slack">
         <span class="provider-logo slack"></span> Go back to Slack
       </a>
     </p>

diff --git a/src/sentry/testutils/helpers/plugins.py b/src/sentry/testutils/helpers/plugins.py
diff --git a/tests/acceptance/sentry_plugins/__init__.py → tests/acceptance/chartcuterie/__init__.py b/tests/acceptance/sentry_plugins/__init__.py → tests/acceptance/chartcuterie/__init__.py
diff --git a/tests/acceptance/chartcuterie/test_chart_renderer.py b/tests/acceptance/chartcuterie/test_chart_renderer.py
@@ -12,6 +12,8 @@ def test_debug_renders(self):
         with self.options(options):
             self.browser.get("debug/chart-renderer/")
 
+        self.wait_for_loading()
+
         images = self.browser.elements(selector="img")
         assert len(images) > 0
 

diff --git a/tests/acceptance/chartcuterie/test_image_block_builder.py b/tests/acceptance/chartcuterie/test_image_block_builder.py
@@ -12,11 +12,7 @@
     ProfileFunctionRegressionType,
 )
 from sentry.models.group import Group
-from sentry.testutils.cases import (
-    AcceptanceTestCase,
-    MetricsEnhancedPerformanceTestCase,
-    ProfilesSnubaTestCase,
-)
+from sentry.testutils.cases import MetricsEnhancedPerformanceTestCase, ProfilesSnubaTestCase
 from sentry.testutils.helpers.datetime import before_now
 from sentry.testutils.helpers.features import with_feature
 from tests.sentry.issues.test_utils import OccurrenceTestMixin
@@ -25,7 +21,6 @@
 
 
 class TestSlackImageBlockBuilder(
-    AcceptanceTestCase,
     MetricsEnhancedPerformanceTestCase,
     ProfilesSnubaTestCase,
     OccurrenceTestMixin,

diff --git a/tests/acceptance/sentry_plugins/test_amazon_sqs.py b/tests/acceptance/sentry_plugins/test_amazon_sqs.py
diff --git a/tests/acceptance/sentry_plugins/test_asana.py b/tests/acceptance/sentry_plugins/test_asana.py
diff --git a/tests/acceptance/sentry_plugins/test_bitbucket.py b/tests/acceptance/sentry_plugins/test_bitbucket.py
diff --git a/tests/acceptance/sentry_plugins/test_github.py b/tests/acceptance/sentry_plugins/test_github.py
diff --git a/tests/acceptance/sentry_plugins/test_gitlab.py b/tests/acceptance/sentry_plugins/test_gitlab.py
diff --git a/tests/acceptance/sentry_plugins/test_jira.py b/tests/acceptance/sentry_plugins/test_jira.py
diff --git a/tests/acceptance/sentry_plugins/test_pagerduty.py b/tests/acceptance/sentry_plugins/test_pagerduty.py
diff --git a/tests/acceptance/sentry_plugins/test_pivotal.py b/tests/acceptance/sentry_plugins/test_pivotal.py
diff --git a/tests/acceptance/sentry_plugins/test_pushover.py b/tests/acceptance/sentry_plugins/test_pushover.py
diff --git a/tests/acceptance/sentry_plugins/test_segment.py b/tests/acceptance/sentry_plugins/test_segment.py
diff --git a/tests/acceptance/sentry_plugins/test_sessionstack.py b/tests/acceptance/sentry_plugins/test_sessionstack.py
diff --git a/tests/acceptance/sentry_plugins/test_slack.py b/tests/acceptance/sentry_plugins/test_slack.py
diff --git a/tests/acceptance/sentry_plugins/test_splunk.py b/tests/acceptance/sentry_plugins/test_splunk.py
diff --git a/tests/acceptance/sentry_plugins/test_victorops.py b/tests/acceptance/sentry_plugins/test_victorops.py
diff --git a/tests/acceptance/test_link_team.py b/tests/acceptance/test_link_team.py
@@ -70,6 +70,8 @@ def test_link_team(self):
         self.browser.click(f'[value="{self.team.id}"]')
         self.browser.click('[type="submit"]')
         self.browser.wait_until_not(".loading")
+        # Ensure we get to the next page before checking for the ExternalActor
+        self.browser.wait_until_test_id("back-to-slack")
 
         assert ExternalActor.objects.filter(
             team_id=self.team.id,
@@ -96,6 +98,8 @@ def test_link_team_as_team_admin(self):
         self.browser.click(f'[value="{self.team.id}"]')
         self.browser.click('[type="submit"]')
         self.browser.wait_until_not(".loading")
+        # Ensure we get to the next page before checking for the ExternalActor
+        self.browser.wait_until_test_id("back-to-slack")
 
         assert ExternalActor.objects.filter(
             team_id=self.team.id,