ref(releases): Rebuild ReleasesPromo #98061
Conversation
github-actions
bot
added
the
Scope: Frontend
There was a problem hiding this comment.
The code LGTM but the behaviour seems weird:
- I can see the "Token From" dropdown on the preview deploy, but I don't see anything like that in production on my user. Is the permission check bugged?
- When I change the token in the dropdown, it doesn't update the code snippet
|
Believe it or not, this is actually the same behavior in prod right now -- It's hard to notice, but there's a 
Clicking that gives you a integration selection. Clicking an item in this list actually creates a new token for this integration (it ALWAYS does this). If you don't have permission however it won't be able to do this, so nothing happens, just like in this new version. The behavior here actually hasn't changed |
|
I'd like to merge this as is, so we can unblock the removal of The right behavior is probably to make an API query to get the list of tokens for the selected integration, and if there's no tokens we can give a warning to the user that they don't have permission to create a token for the selected app. |
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-releases-rebuild-releasespromo
branch
from
66a956b to
ac3b3b9
Compare
- Replaces the deprecated dropdownAutoComplete with a CompactSelect - Removes the complex logic to have a <click here for token> with a much simpler interface that uses a familiar drop-down to select the integration to use a token from.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-releases-rebuild-releasespromo
branch
from
ac3b3b9 to
dad0741
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| triggerLabel={selectedApp ? undefined : t('Select Integration')} | ||
| triggerProps={{prefix: selectedApp ? t('Token From') : undefined}} | ||
| onChange={option => { | ||
| const app = apps.find(i => i.slug === option.value)!; |
There was a problem hiding this comment.
Bug: Unsafe Non-Null Assertion in onChange Handler
The non-null assertion operator (!) on apps.find() in the CompactSelect's onChange handler can lead to a runtime error. If the selected option's value doesn't match an existing app (e.g., due to race conditions or data inconsistencies), apps.find() returns undefined, causing a crash.
evanpurkhiser
deleted the
evanpurkhiser/ref-releases-rebuild-releasespromo
branch
- Replaces the deprecated dropdownAutoComplete with a CompactSelect - Removes the complex logic to have a <click here for token> with a much simpler interface that uses a familiar drop-down to select the integration to use a token from. See example here https://sentry-kajlvytky.sentry.dev/explore/releases/?project=4503972821204992
- Replaces the deprecated dropdownAutoComplete with a CompactSelect - Removes the complex logic to have a <click here for token> with a much simpler interface that uses a familiar drop-down to select the integration to use a token from. See example here https://sentry-kajlvytky.sentry.dev/explore/releases/?project=4503972821204992
Replaces the deprecated dropdownAutoComplete with a CompactSelect
Removes the complex logic to have a with a much
simpler interface that uses a familiar drop-down to select the
integration to use a token from.
See example here https://sentry-kajlvytky.sentry.dev/explore/releases/?project=4503972821204992