-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Revive the CTS job #7675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Revive the CTS job #7675
Conversation
27be211
to
2f220ec
Compare
jobs: | ||
cts: | ||
# For pull requests, run only run if we add the "PR: run CTS" label | ||
if: "github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'PR: run CTS'))" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried a bunch of versions of this, and GitHub kept saying it was an error in the yaml syntax. But I'm not sure if this one is correct, or if it's interpreted as a non-null string that will always be true.
Clippy is probably on to something here:
|
I am going to mark this as a draft and open separate PRs for the functional changes. |
Fixes #6838
Includes some functional changes to make it work, notably:
GPUDevice.lost
produce a promise (it did not seem to do so, before). But I don't know how to trigger resolution of the promise when device loss occurs.on_submitted_work_done
in deno_webgpu similar to howmapAsync
is implemented.destroy()
is called multiple times.A pinned CTS version is specified in
cts_runner/revision.txt
. That version is quite old, but is not changed by this PR, because there is a problem running the latest version in deno. gpuweb/cts#4385 has the fix for that.Testing
I tested the CTS job in my personal fork of wgpu. We can also verify that the CTS job runs on this PR (based on a label being set). The
workflow_dispatch
trigger only works once the workflow is merged to main.Squash or Rebase? Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.