Compatibility with ggplot2 4.0.0 #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may not be perfect for today, but I am EXTREMELY excited about S7's double dispatch and look forward to removing GGally's |
|
Glad that we can finally get there after (5!) years since tidyverse/ggplot2#3818 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Barret and team,
We've been preparing for a new major release of ggplot2, which includes some changes that were incompatible with GGally.
The major thing is that we're adopting S7 as OOP system (tidyverse/ggplot2#6364), which had some troubles with
GGally::.+.ggThis PR should align the two packages.
In addition, there are some visual tests that may need updating which isn't included in this PR.
Best wishes,
Teun