-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Reimplement classes in S7 #6364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit b038e8f.
I think it is necessary to make
|
Merge branch 'main' into S7_objects # Conflicts: # R/guides-.R
This is my take on the revdepcheck as it stands. Of the 648 packages that I've annotated:
|
Please bump the version to something like |
I don't see how we can further minimise the impact of this PR without abandoning the S7 transition altogether. I'll merge this into main so I can send out some PRs and instruct to check with the dev version, which is easier than check with a PR. |
This PR aims to fix a large part of #6352.
Briefly it implements the following S7 classes:
I've put in the usual extractors and replacers (
[
,[[
,$
and their<-
methods) for the ggplot/ggplot_built classes for backwards compatibility. The code internally now uses@
though, so that we can deprecate the usual extractors/replacers later.