Fix CacheSequenceResolver for Redis with Compression & Serialization #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code is now compatible with Compression and Serialization enabled for Redis. The implementation is the same as Laravel used for RateLimiting using Redis. [src/Illuminate/Cache/RateLimiter.php](https://github.com/laravel/framework/blob/5d477f9a4080c1cdd43edd05ec4df61c738e0f8d/src/Illuminate/Cache/RateLimiter.php#L161) Without this change, I get this error when trying to create a snowflake ID: ``` InvalidArgumentException Sequences must be an integer between 0 and 4095 (got -1). ```
|
cc: @inxilpro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code is now compatible with Compression and Serialization enabled for Redis.
The implementation is the same as Laravel used for RateLimiting using Redis.
Had to recreate the logic as it is not available on Laravel < 11.x
src/Illuminate/Cache/RateLimiter.php
Without this change, I get this error when trying to create a snowflake ID: