Skip to content

feat: add MSB icon#444

Open
PhatJack wants to merge 2 commits into
glincker:mainfrom
PhatJack:feat/icon-msb
Open

feat: add MSB icon#444
PhatJack wants to merge 2 commits into
glincker:mainfrom
PhatJack:feat/icon-msb

Conversation

@PhatJack
Copy link
Copy Markdown
Contributor

Onboards Vietnam Maritime Commercial Joint Stock Bank (https://www.msb.com.vn/) to the brand catalog.

Field Value
slug msb
title Vietnam Maritime Commercial Joint Stock Bank
hex 9E0B0F
categories Finance
url https://www.msb.com.vn/
collection brands
dateAdded 2026-05-28
license CC0-1.0

@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label May 28, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Greptile Summary

Adds MSB (Vietnam Maritime Commercial Joint Stock Bank) to the brand catalog with a standalone icon and a wordmark variant, plus the corresponding icons.json entry.

  • public/icons/msb/default.svg: New icon-only SVG using four radial gradient-filled paths; the clipPath rectangle (3953×1163) does not match the viewBox (1623×936), making the clip region effectively a no-op.
  • public/icons/msb/wordmark.svg: New combined icon + text SVG; the clipPath correctly matches its viewBox (1519×447); both files share the same internal IDs (cp1, g1g4, Clip-Path), which can cause gradient cross-contamination if both are ever inlined in the same document.
  • src/data/icons.json: MSB entry appended with all required fields (slug, title, hex, categories, variants, license, url, collection, dateAdded).

Confidence Score: 5/5

Safe to merge — the changes are additive (new SVG assets and one JSON entry) with no modifications to existing data or logic.

All three files are purely additive. The JSON entry is well-formed and carries all required fields. The SVG assets render the correct brand colours and shapes; the only structural quirks (oversized clipPath in the icon file, shared IDs across files) are pre-existing SVG authoring artefacts that do not break current rendering.

No files require special attention beyond the previously flagged clipPath mismatch in public/icons/msb/default.svg.

Important Files Changed

Filename Overview
public/icons/msb/default.svg New icon SVG — gradients and paths look correct, but the clipPath rectangle (3953×1163) far exceeds the viewBox (1623×936), making the clip region dead markup; IDs also collide with wordmark.svg.
public/icons/msb/wordmark.svg New wordmark SVG — clipPath correctly matches the viewBox (1519×447); contains tab characters embedded in several path d attributes; shares all gradient/clip IDs with default.svg.
src/data/icons.json MSB entry added with all required fields; opening brace uses a tab instead of the two-space indent used by every other entry (flagged in previous review thread).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[icons.json entry\nslug: msb] --> B[default variant\n/icons/msb/default.svg]
    A --> C[wordmark variant\n/icons/msb/wordmark.svg]
    B --> D[4 gradient-filled paths\ng1–g4 radial gradients\nclipPath cp1 ⚠️ oversized]
    C --> E[Icon paths\ng1–g4 radial gradients\nclipPath cp1 ✅ matches viewBox]
    C --> F[Text paths\nMSB lettering fill #000\nTagline fill #ef4123]
    D -. shared IDs .-> E
Loading

Reviews (2): Last reviewed commit: "refactor(svg): remove duplicate id attri..." | Re-trigger Greptile

Comment thread src/data/icons.json
Comment on lines +115548 to +115550
},
{
"slug": "msb",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The opening brace for the MSB entry is indented with a tab character, while every other entry in the file uses two spaces. This inconsistency will fail any JSON-formatting lint check the project runs and makes the diff harder to read.

Suggested change
},
{
"slug": "msb",
},
{
"slug": "msb",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread public/icons/msb/default.svg Outdated
Comment on lines +4 to +6
<clipPath clipPathUnits="userSpaceOnUse" id="cp1">
<path d="m3953.29 0v1163.44h-3953.29v-1163.44z"/>
</clipPath>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 clipPath dimensions don't match the viewBox

The clip-path rectangle spans 3953.29 × 1163.44 user units, while the viewBox is 0 0 1623 936. This looks like a leftover from the original authoring tool's artboard size. The mismatch means the clip path never actually clips any visible content — it's dead markup. It should either be removed or updated to match the viewBox (0 0 1623 936) to make the intent clear and keep the file clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant