Skip to content

feat: add MSB icon #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thegdsks merged 2 commits into from
Jun 7, 2026
Merged

feat: add MSB icon #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df8bb77
feat: add MSB icon
PhatJack May 28, 2026
8cc42a7
refactor(svg): remove duplicate id attributes from paths in MSB icon
PhatJack May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions public/icons/msb/default.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
54 changes: 54 additions & 0 deletions public/icons/msb/wordmark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 17 additions & 0 deletions src/data/icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115545,6 +115545,23 @@
"url": "",
"collection": "brands",
"dateAdded": "2026-05-05"
},
{
"slug": "msb",
Comment on lines +115548 to +115550

@greptile-apps greptile-apps Bot May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The opening brace for the MSB entry is indented with a tab character, while every other entry in the file uses two spaces. This inconsistency will fail any JSON-formatting lint check the project runs and makes the diff harder to read.

Suggested change
},
{
"slug": "msb",
},
{
"slug": "msb",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"title": "Vietnam Maritime Commercial Joint Stock Bank",
"aliases": [],
"hex": "9E0B0F",
"categories": [
"Finance"
],
"variants": {
"default": "/icons/msb/default.svg",
"wordmark": "/icons/msb/wordmark.svg"
},
"license": "CC0-1.0",
"url": "https://www.msb.com.vn/",
"collection": "brands",
"dateAdded": "2026-05-28"
},
{
"slug": "msdos",
Expand Down
Loading