feat: add Sandisk icon#450
Conversation
Greptile SummaryThis PR onboards SanDisk to the brand catalog, adding three SVG variants (default, mono, wordmark) and a new entry in
Confidence Score: 3/5Not safe to merge as-is — the SanDisk entry will be catalogued under "Software" and "Platform", which are factually wrong for a storage hardware brand. The SVG assets look correct, but the JSON metadata ships two wrong category tags that would immediately mislabel SanDisk for anyone browsing or filtering the catalog by category. The indentation inconsistency is minor but also worth fixing before merge. src/data/icons.json — the categories array and the tab-indented opening brace both need correction.
|
| Filename | Overview |
|---|---|
| src/data/icons.json | New SanDisk entry added with incorrect categories ("Software", "Platform" should be removed — only "Hardware" applies) and a tab-indented opening brace inconsistent with the rest of the file. |
| public/icons/sandisk/default.svg | Colored SVG icon added with correct brand hex (#E10600); missing trailing newline. |
| public/icons/sandisk/mono.svg | Monochrome SVG icon added (no fill color attribute); missing trailing newline. |
| public/icons/sandisk/wordmark.svg | Wordmark SVG added with full text paths at brand red; has trailing newline but omits version="1.2" unlike the other two variants. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[icons.json entry
slug: sandisk] --> B[default.svg
fill: #E10600]
A --> C[mono.svg
no fill]
A --> D[wordmark.svg
fill: #E10600]
A --> E{categories}
E --> F["✅ Hardware"]
E --> G["❌ Software (incorrect)"]
E --> H["❌ Platform (incorrect)"]
Reviews (1): Last reviewed commit: "feat: add Sandisk icon" | Re-trigger Greptile
| "categories": [ | ||
| "Software", | ||
| "Platform", | ||
| "Hardware" | ||
| ], |
There was a problem hiding this comment.
The
categories array includes "Software" and "Platform", but SanDisk is a storage hardware brand (flash drives, SSDs, memory cards) with no software or platform product line. These two categories appear to have been accidentally copied from the preceding san-francisco-municipal-railway entry. Only "Hardware" matches what the PR description specifies and what the brand actually represents.
| "categories": [ | |
| "Software", | |
| "Platform", | |
| "Hardware" | |
| ], | |
| "categories": [ | |
| "Hardware" | |
| ], |
| }, | ||
| { | ||
| "slug": "sandisk", |
There was a problem hiding this comment.
The opening brace of the new entry uses a tab character, while every other entry in the file uses two spaces of indentation. This makes the file inconsistent and can break JSON linters or diff tools that flag mixed indentation.
| }, | |
| { | |
| "slug": "sandisk", | |
| }, | |
| { | |
| "slug": "sandisk", |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Onboards Sandisk (https://www.sandisk.com) to the brand catalog.
E10600