Skip to content

feat: add Sandisk icon#450

Open
PhatJack wants to merge 1 commit into
glincker:mainfrom
PhatJack:feat/icon-sandisk
Open

feat: add Sandisk icon#450
PhatJack wants to merge 1 commit into
glincker:mainfrom
PhatJack:feat/icon-sandisk

Conversation

@PhatJack
Copy link
Copy Markdown
Contributor

Onboards Sandisk (https://www.sandisk.com) to the brand catalog.

Field Value
slug sandisk
title Sandisk
hex E10600
categories Hardware
url https://www.sandisk.com
collection brands
dateAdded 2026-05-29
license CC0-1.0

@github-actions github-actions Bot added the icons Icon data, SVGs, or variants label May 29, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Greptile Summary

This PR onboards SanDisk to the brand catalog, adding three SVG variants (default, mono, wordmark) and a new entry in icons.json. The SVGs render the correct brand shape in the declared hex E10600, but the metadata entry needs attention before merging.

  • The categories array incorrectly includes "Software" and "Platform" — inherited from the immediately preceding entry — when SanDisk is exclusively a hardware brand; only "Hardware" should remain.
  • The opening brace of the new JSON object uses a tab character instead of the two-space indentation used by every other entry in the file.
  • default.svg and mono.svg are both missing a trailing newline, and wordmark.svg omits the version="1.2" attribute present on the other two variants.

Confidence Score: 3/5

Not safe to merge as-is — the SanDisk entry will be catalogued under "Software" and "Platform", which are factually wrong for a storage hardware brand.

The SVG assets look correct, but the JSON metadata ships two wrong category tags that would immediately mislabel SanDisk for anyone browsing or filtering the catalog by category. The indentation inconsistency is minor but also worth fixing before merge.

src/data/icons.json — the categories array and the tab-indented opening brace both need correction.

Important Files Changed

Filename Overview
src/data/icons.json New SanDisk entry added with incorrect categories ("Software", "Platform" should be removed — only "Hardware" applies) and a tab-indented opening brace inconsistent with the rest of the file.
public/icons/sandisk/default.svg Colored SVG icon added with correct brand hex (#E10600); missing trailing newline.
public/icons/sandisk/mono.svg Monochrome SVG icon added (no fill color attribute); missing trailing newline.
public/icons/sandisk/wordmark.svg Wordmark SVG added with full text paths at brand red; has trailing newline but omits version="1.2" unlike the other two variants.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[icons.json entry
 slug: sandisk] --> B[default.svg
 fill: #E10600]
    A --> C[mono.svg
 no fill]
    A --> D[wordmark.svg
 fill: #E10600]
    A --> E{categories}
    E --> F["✅ Hardware"]
    E --> G["❌ Software (incorrect)"]
    E --> H["❌ Platform (incorrect)"]
Loading

Reviews (1): Last reviewed commit: "feat: add Sandisk icon" | Re-trigger Greptile

Comment thread src/data/icons.json
Comment on lines +93749 to +93753
"categories": [
"Software",
"Platform",
"Hardware"
],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The categories array includes "Software" and "Platform", but SanDisk is a storage hardware brand (flash drives, SSDs, memory cards) with no software or platform product line. These two categories appear to have been accidentally copied from the preceding san-francisco-municipal-railway entry. Only "Hardware" matches what the PR description specifies and what the brand actually represents.

Suggested change
"categories": [
"Software",
"Platform",
"Hardware"
],
"categories": [
"Hardware"
],

Comment thread src/data/icons.json
Comment on lines +93743 to +93745
},
{
"slug": "sandisk",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The opening brace of the new entry uses a tab character, while every other entry in the file uses two spaces of indentation. This makes the file inconsistent and can break JSON linters or diff tools that flag mixed indentation.

Suggested change
},
{
"slug": "sandisk",
},
{
"slug": "sandisk",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons Icon data, SVGs, or variants

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant