Skip to content

feat: add Sandisk icon #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thegdsks merged 1 commit into from
Jun 7, 2026
+39 −0
Merged

feat: add Sandisk icon #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions public/icons/sandisk/default.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions public/icons/sandisk/mono.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 13 additions & 0 deletions public/icons/sandisk/wordmark.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 20 additions & 0 deletions src/data/icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93740,6 +93740,26 @@
"url": "https://www.actransit.org/wp-content/uploads/HSP_CC-sched.pdf",
"dateAdded": "2026-03-07",
"collection": "brands"
},
{
"slug": "sandisk",
Comment on lines +93743 to +93745
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The opening brace of the new entry uses a tab character, while every other entry in the file uses two spaces of indentation. This makes the file inconsistent and can break JSON linters or diff tools that flag mixed indentation.

Suggested change
},
{
"slug": "sandisk",
},
{
"slug": "sandisk",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"title": "SanDisk",
"aliases": [],
"hex": "E10600",
"categories": [
"Software",
"Platform",
"Hardware"
],
Comment on lines +93749 to +93753
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The categories array includes "Software" and "Platform", but SanDisk is a storage hardware brand (flash drives, SSDs, memory cards) with no software or platform product line. These two categories appear to have been accidentally copied from the preceding san-francisco-municipal-railway entry. Only "Hardware" matches what the PR description specifies and what the brand actually represents.

Suggested change
"categories": [
"Software",
"Platform",
"Hardware"
],
"categories": [
"Hardware"
],

"variants": {
"default": "/icons/sandisk/default.svg",
"mono": "/icons/sandisk/mono.svg",
"wordmark": "/icons/sandisk/wordmark.svg"
},
"license": "CC0-1.0",
"url": "https://www.sandisk.com",
"dateAdded": "2026-05-29",
"collection": "brands"
},
{
"slug": "sanic",
Expand Down
Loading