Fix and simplify getHomeDir #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commits 99fac80 and ec919d8 it's clear that getHomeDir is only used on Windows. Ironically, $HOME is not used on Windows (instead, it's %USERPROFILE%), so we always fallback to user.Current, which internally uses os.UserHomeDir to fill in HomeDir. So, let's just use os.UserHomeDir directly (and fall back to "/" in case of an error like the previous implementation did). Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commits 99fac80 and ec919d8 (PR #418) it's clear that
getHomeDiris only used on Windows.Ironically,
$HOMEis not used on Windows (instead, it's%USERPROFILE%), so the code always falls back to user.Current, which internally uses os.UserHomeDir to fill inHomeDir.So, it is both simpler and more correct to use os.UserHomeDir directly. Fall back to "/" in case of an error like the previous implementation did.